Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com To: Eric Blake Cc: "Pierre A. Humblet" , cygwin@cygwin.com, bug-coreutils@gnu.org Subject: Re: mkdir -p and network drives References: <3.0.5.32.20050502232204.00b52180@incoming.verizon.net> <42777719.8090103@byu.net> <8764xym6vf.fsf@penguin.cs.ucla.edu> <427AD935.1010409@byu.net> From: Paul Eggert Date: Thu, 05 May 2005 20:47:00 -0700 In-Reply-To: <427AD935.1010409@byu.net> (Eric Blake's message of "Thu, 05 May 2005 20:40:53 -0600") Message-ID: <87vf5x818r.fsf@penguin.cs.ucla.edu> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Eric Blake writes: >> + if (do_chdir && dirpath[0] == '/') >> + { >> + /* POSIX says "//" might be special, so chdir to "//" if the >> + file name starts with exactly two slashes. */ >> + char const *root = "//" + (dirpath[1] != '/' || dirpath[2] == '/'); > > Oops - buffer overflow bug. dirpath[2] is past the end of the string on > dirpath of "/", If dirpath is "/", then dirpath[1] != '/' is true, so dirpath[2] isn't evaluated. -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/