Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com Message-ID: <03da01c4eea2$bcec1e40$5308a8c0@robinson.cam.ac.uk> From: "Max Bowsher" To: References: <02e901c4ee99$48826a90$5308a8c0@robinson.cam.ac.uk> <20041230185131.GD1212@trixie.casa.cgf.cx> Subject: Re: Bug: Missing va_end() in cygwin_internal() Date: Thu, 30 Dec 2004 19:05:29 -0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Christopher Faylor wrote: > On Thu, Dec 30, 2004 at 05:59:02PM -0000, Max Bowsher wrote: >> There is no va_end() call in cygwin_internal(). > > Or in functions from: > > bsdlib.cc > fork.cc > pinfo.cc > strace.cc > > The lack doesn't seem to be causing much of a problem... Standards say va_end is required, but may be a noop in some implementations. I peered at the guts of gcc trying to work out whether that was the case for cygwin, but got too lost to be sure. I thought it was worth mentioning, because I think I'm going to need to use cygwin_internal(CW_GET_BINMODE, ...) a lot, in order to get Subversion's "native" eol-style feature noticing textmode mounts. Max. -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/