Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Message-ID: <414749A7.809@agilent.com>
Date: Tue, 14 Sep 2004 12:42:31 -0700
From: Earl Chew <earl_chew@agilent.com>
User-Agent: Mozilla Thunderbird 0.5 (Windows/20040207)
MIME-Version: 1.0
To: cygwin@cygwin.com
Subject: Re: BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c
References: <414532D7.8050506@agilent.com> <41472B3F.8030800@agilent.com>
In-Reply-To: <41472B3F.8030800@agilent.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Christopher Faylor wrote:
> Let me again point out that a cygwin program shouldn't be doing *ANY OF
> THIS*.
> 
> It shouldn't be calling GetFileSize and it shouldn't be calling
> CreateFile.

I think part of the original motivation might have been that under
some circumstances this set of programs needs to be used on
drive partitions as opposed to files within those partitions.

At that time there may have been no way within Cygwin to size
a partition (statfs()?).

As far as I can tell the O_BINARY changes are good to have.

Earl

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/