Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com To: cygwin@cygwin.com Subject: Re: RTLD_DEFAULT & RTLD_NEXT Mail-Copies-To: never Reply-To: sds@gnu.org X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. From: Sam Steingold In-Reply-To: <20040831190826.GV17670@cygbert.vinschen.de> (Corinna Vinschen's message of "Tue, 31 Aug 2004 21:08:26 +0200") References: <20040830143832.GE17670@cygbert.vinschen.de> <20040831083258.GA7517@cygbert.vinschen.de> <20040831190826.GV17670@cygbert.vinschen.de> Mail-Followup-To: cygwin@cygwin.com Date: Tue, 31 Aug 2004 15:35:34 -0400 Message-ID: User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain > * Corinna Vinschen [2004-08-31 21:08:26 +0200]: > > On Aug 31 11:24, Sam Steingold wrote: >> > * Corinna Vinschen [2004-08-31 10:32:58 +0200]: >> > EnumProcessModules. This should also allow to implement RTLD_DEFAULT. >> >> 2004-08-31 Sam Steingold >> >> * dlfcn.cc (dlsym): Handle RTLD_DEFAULT using EnumProcessModules(). >> * include/dlfcn.h (RTLD_DEFAULT): Define to NULL. > > thanks but... well, there are a couple of problems: > > - Please send patches to cygwin-patches@... did. > - Your code doesn't follow the GNU coding style. yuk!!! > - EnumProcessModules is NT >= 4 only but not loaded dynamically (see > autoload.cc) nor tested for non-existance. Generally, > EnumProcessModules is called w/o checking the return value. 1. what is "n" in LoadDLLfunc? 2. how do I test for non-existance? 3. the first call to EnumProcessModules is known to fail. it is there for that specific reason - to fail and return "needed". > - This is adding new functionality. It's not much over the usual 10 > lines rule of thumb for trivial patches, but it's not exactly trivial > functionality and it will only grow bigger when adding the autoload > and return value testing code. I'd like to ask you to read > http://cygwin.com/contrib.html and send us a copyright assignment if > possible. ok. -- Sam Steingold (http://www.podval.org/~sds) running w2k A computer scientist is someone who fixes things that aren't broken. -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/