Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com Date: Tue, 31 Aug 2004 21:08:26 +0200 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: RTLD_DEFAULT & RTLD_NEXT Message-ID: <20040831190826.GV17670@cygbert.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20040830143832.GE17670@cygbert.vinschen.de> <20040831083258.GA7517@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2i Hi Sam, On Aug 31 11:24, Sam Steingold wrote: > > * Corinna Vinschen [2004-08-31 10:32:58 +0200]: > > EnumProcessModules. This should also allow to implement RTLD_DEFAULT. > > 2004-08-31 Sam Steingold > > * dlfcn.cc (dlsym): Handle RTLD_DEFAULT using EnumProcessModules(). > * include/dlfcn.h (RTLD_DEFAULT): Define to NULL. thanks but... well, there are a couple of problems: - Please send patches to cygwin-patches@... - Your code doesn't follow the GNU coding style. - EnumProcessModules is NT >= 4 only but not loaded dynamically (see autoload.cc) nor tested for non-existance. Generally, EnumProcessModules is called w/o checking the return value. - This is adding new functionality. It's not much over the usual 10 lines rule of thumb for trivial patches, but it's not exactly trivial functionality and it will only grow bigger when adding the autoload and return value testing code. I'd like to ask you to read http://cygwin.com/contrib.html and send us a copyright assignment if possible. Thanks, Corinna -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/