Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com Date: Wed, 24 Mar 2004 21:39:29 -0500 From: "Pierre A. Humblet" To: cygwin@cygwin.com Subject: Re: lstat on FAT - Was: Problem with find on FAT drives Message-ID: <20040325023929.GA335381@hpn5170x> Mail-Followup-To: "Pierre A. Humblet" , cygwin@cygwin.com References: <4060B627.8000400@scytek.de> <20040324155332.GF17229@cygbert.vinschen.de> <4061E702.1040705@scytek.de> <20040324205644.GA4580@redhat.com> <20040324213057.GA296803@Worldnet> <20040324214239.GA6079@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040324214239.GA6079@redhat.com> User-Agent: Mutt/1.4.1i On Wed, Mar 24, 2004 at 04:42:39PM -0500, Christopher Faylor wrote: > On Wed, Mar 24, 2004 at 04:30:57PM -0500, Pierre A. Humblet wrote: > > > >I also had a look at the code and reached pretty much the same conclusion > >as Volker. Replacing all 'isslash (*src)' and 'isslash (src[x])' in > >normalize_posix_path by "isdirsep ()" would yield more consistent results. > >I know this code is delicate but the possible drawback isn't obvious. > > speed disadvantage for nebulous gain. As you know isdirsep would take 1 extra compare per character. FWIW I see one place where we could avoid the kind of loop that Volker had. I wonder if char *p = strrchr (src, '\0'); /* Detect if the user was looking for a directory. We have to strip the should be inside the symlink loop or outside. I guess that depends if symlink contents ending with / are special (on Sun the final / is stripped in symlinks, dunno about other Unix flavors). Also normalize_posix_path strips the final /, except when it calls normalize_win32_path. That makes the code go through extra hoops when resolving c:/the/symlink/, it looks for c:/the/symlink/.lnk Pierre -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/