Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com From: "Ralf Habacker" To: , Subject: RE: [Patch] skipping import libraries for performance reasons - direct auto-import of dll's Date: Tue, 26 Nov 2002 12:42:28 +0100 Message-ID: <016f01c29540$e5a16380$cd6407d5@BRAMSCHE> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal In-reply-to: <015201c2951d$c889a7d0$cd6407d5@BRAMSCHE> Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 > > -----Original Message----- > > From: binutils-owner@sources.redhat.com > > [mailto:binutils-owner@sources.redhat.com]On Behalf Of Christopher > > Faylor > > Sent: Tuesday, November 26, 2002 2:42 AM > > To: Binutils; cygwin@cygwin.com > > Subject: Re: [Patch] skipping import libraries for performance reasons - > > direct auto-import of dll's > > > > > > On Mon, Nov 25, 2002 at 11:50:13PM +0100, Ralf Habacker wrote: > > >Chuck Wilson wrote: > > >>Minor nit about patch format: watch out for your tab/indentation. It > > >>doesn't match the surrounding text in many cases. > > > > > >Okay. How are the tab width ? > > > > It's the standard 8 characters per tab. You also aren't adhering to GNU > > coding standards and a ChangeLog would be nice. > > > Okay, I will try. Hmmh, there are problems. In pe-dll.c for example, several lines are indented with tabs, other with tabs and spaces and other with two spaces for each indention level. Which should I use ? The easiest way for such problems seems to me to suggest an indent command line, which everyone who is going to build a patch could apply before to ensure the standards. Is anyone there who can provide such an indent command line ? ChangeLog 2002-11-26 Ralf Habacker * deffile.h (struct def_file_import): new element 'data' supports data imports from dlls. * pe-dll.c (pe_implied_import_dll): use import dll name from dll instead from filename. Identify and flag data imports from dll. * emultempl/pe.em (gld_${EMULATION_NAME}_after_open): call auto-import handling after dll importing stuff to support auto-importing from dll's. -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/