Mailing-List: contact cygwin-help@sourceware.cygnus.com; run by ezmlm
Sender: cygwin-owner@sources.redhat.com
Message-ID: <3B1DADBE.811853DD@ece.gatech.edu>
Date: Wed, 06 Jun 2001 00:12:46 -0400
From: "Charles S. Wilson" <cwilson@ece.gatech.edu>
MIME-Version: 1.0
To: Jason Tishler <Jason.Tishler@dothill.com>
CC: Cygwin Users <cygwin@cygwin.com>
Subject: Re: [avail for test] readline-4.2-1
References: <20010605113203.B490@dothill.com> <3B1CFE49.20A885CA@yahoo.com> <3B1D94F9.F6FADE8F@ece.gatech.edu> <20010605225519.B3095@dothill.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Jason Tishler wrote:
> > Yes, would you like to take over maintainership for the cygwin-readline
> > package?
> 
> Boy did I step in it! :,)
> 
> I have been contemplating the acceptance of this role, but to be honest
> I don't relish the responsibility given that the Cygwin specific patch
> is almost 200K.  

Take a look at the patch; there are very few if any *substantive*
changes in the library. It's almost entirely changing

int
my_function (args)
to
READLINE_EXPORT(int,my_function) (args)

and

extern int foobar;
to
READLINE_EXPORT_VAR(int) foobar;

However, since there are SO MANY entry points in this library, that adds
up to a lot of changes.  The reason the 4.1-4.2 transition was so
painful was because Chet cleaned up a lot of the definitions, adding
'const' qualifiers to many of the function arguments -- and thus, the
old patch wouldn't apply.  (I don't think he's going to do that
again...)

> Have you approached Chet regarding acceptance of your
> patch into readline CVS?  

I did, at one point.  He was unenthusiastic since it really uglifies the
source.  I will try again.

> If Chet is willing to accept your patch,
> then I could probably be convinced.

Okay.  Thanks,
Chuck

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple