Subject: RE: trying to compile PostgreSQL 7.0 on cygwin 1.1.2
From: David Robinow <[email-masked]>
To: Joost Kraaijeveld <[email-masked]>, "'Gregory Krasnow'" <[email-masked]>
Cc: "Cygwin@Sourceware. Cygnus. Com \(E-mail\)" <[email-masked]>
Date: Fri, 9 Jun 2000 07:38:21 -0700 (PDT)

--- Joost Kraaijeveld <[email-masked]>
wrote:

> In /src/backend/utils/error/elog.c and
> /src/backend/utils/error/exc.c
> you have t change
> 
> 	extern int	sys_nerr;
> 
> 	to
> 
> 	#ifdef __CYGWIN__
> 	#  define sys_nerr _sys_nerr
> 	#else
> 	   extern int sys_nerr;
> 	#endif
> 
 This is really terrible advice. Please don't do this.
As Chris already mentioned the correct solution is to
#include <errno.h>

 It's generally bad practice to include
platform-specific solutions in source code when there
are alternatives. The fact is the program in question
had a bug (failure to "#include <errno.h>") and it
should be fixed.
 The old-fashioned Unix error handling is not
thread-safe and is likely to break on other systems
than just Cygwin.

__________________________________________________
Do You Yahoo!?
Yahoo! Photos -- now, 100 FREE prints!
http://photos.yahoo.com

--
Want to unsubscribe from this list?
Send a message to [email-masked]