Subject: Re: FW: Missing strtoull()...: long long standard
From: [email-masked] (Fergus Henderson)

20 Jul 1998 08:01:19 -0700
Message-ID: <[email-masked]>
References: <[email-masked]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: root <[email-masked]>
Cc: Brendan Simon <[email-masked]>, [email-masked]

On 19-Jul-1998, root <[email-masked]> wrote:
> As to strtoll, my system uses atoll, what should be equivalent...
> It is not that complicated actually...
> 
> Here it is:
> ----------------------------------------------------- strtoll.c-----------
> long long _strtoll(char *str)
> {
>         long long result = 0;
>         int negative=0;
> 
>         while (*str == ' ' || *str == '\t')
>                 str++;
>         if (*str == '+')
>                 str++;
>         else if (*str == '-') {
>                 negative = 1;
>                 str++;
>         }
> 
>         while (*str >= '0' && *str <= '9') {
>                 result = (result*10)+(*str++ - '0');
>         }
>         return negative ? -result : result;
> }

That version is buggy; it won't handle the most negative number correctly.

I think changing the last few lines to
	
                 result = (result*10) - (*str++ - '0');
         }
         return negative ? result : -result;

should fix the bug.

-- 
Fergus Henderson <[email-masked]>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger [email-masked]        |     -- the last words of T. S. Garp.
-
For help on using this list (especially unsubscribing), send a message to
"[email-masked]" with one line of text: "help".