delorie.com/archives/browse.cgi   search  
Mail Archives: geda-user/2017/11/28/18:04:47

X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Wed, 29 Nov 2017 00:02:11 +0100 (CET)
From: Roland Lutz <rlutz AT hedmen DOT org>
To: "Peter Stuge (peter AT stuge DOT se) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Subject: Re: [geda-user] Object data validation/normalization
In-Reply-To: <20171128202058.GX4167@stuge.se>
Message-ID: <alpine.DEB.2.20.1711282356140.1454@nimbus>
References: <alpine DOT DEB DOT 2 DOT 20 DOT 1711281711160 DOT 1906 AT nimbus> <20171128202058 DOT GX4167 AT stuge DOT se>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com

On Tue, 28 Nov 2017, Peter Stuge (peter AT stuge DOT se) [via 
geda-user AT delorie DOT com] wrote:
> Roland Lutz wrote:
>> However, there were several places in the code which relied on storing 
>> technically invalid values in some fields; most importantly, unused 
>> fields were set to -1 internally.
>
> But they were never used? Eh, all right.. Good to fix that.

They were used, the code relied on these values.  For example, when 
writing to file, the line/fill attributes were written straight out to 
disk; that's why unused attributes appear as -1 in the file format.

I changed that code so unused attributes are always written as -1, 
disregarding the actual value (which would have been normalized to 0). 
The old values are still used in libgeda, though, but that's an entirely 
different issue...

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019