Mail Archives: geda-user/2017/02/12/14:06:12
On Sun, 12 Feb 2017, Roland Lutz wrote:
> On Sun, 12 Feb 2017, gedau AT igor2 DOT repo DOT hu wrote:
>> I am not pushing it because I'd need it for pcb-rnd. I already have a
>> gaf "fork: with fully working back annot for myself and for those who
>> want to use the feature, so honestly, as an user or developer I don't
>> really care if it makes it into any of the other "forks".
>
> To make it more visible, I added your code to the geda-gaf repository as
> the branch home/rlutz/igor2-ba.
>
> After a first look at it, I think the code would need some cleanup, but
> I don't see a fundamental reason why it shouldn't be merged into
> geda-gaf. I wouldn't be comfortable deciding this on my own, though.
Ok, I now cleaned up the build system stuff, fixed two bugs and the
compiler warnings, rebased it to what appears to be the last common commit
shared with Vladimir's code and pushed it as home/rlutz/back-annotation.
I can't give the code a proper review, though, because I don't understand
the gschem code (especially the text search) well enough.
I'm not sure how to proceed from here. Is anyone familiar with the gschem
internals willing to have a look at the code? Or should I just merge it?
The commit history doesn't appear to be very useful; should I squash it
into one commit?
- Raw text -