X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type;
	bh=x6XGdRnl3sbTMcZ3EHjPfnEJqIjoZBDG9z2x+EQVoh0=;
	b=BZbeRZFthGOL4hZHE/FtZms1DlWnWDu9gLwToQkE63D8s7hFotLUn3NbFcy3lbaZIi
	1IOtS92OTtrDF1ezEAPCUSyOFO1gLPzXVE/f6DKQyg7WIECh1ZSPXA0tl5R3bTnEkUzo
	lQu4qVJ8D9AgjflJ61RAw776OrLXcctG6AMyvPPrP+anJX43y+3CI4wVnsh5FlYQ+vnR
	cn+5/BbVODenkM7wYPDP7QGKA8Be49suqwnQdERGJ0/bxZD4DK6+GQq8zwo91I2g6Mae
	iuHuVbMRPguKGNCNY4g/6w6moPncECvj6o2U43oioz5nNCL+WoankaAaHExD9ECv6AjH
	tr8g==
X-Gm-Message-State:	ALoCoQnq7qYOjSqfixWZYlG11DPWeFyuJRLs4otyFGcrH4GcqMtz9KAmsAvwMoxo3/s62LtdoKqv
X-Received:	by 10.194.95.35 with SMTP id dh3mr154011wjb.94.1388752722729; Fri,
	03 Jan 2014 04:38:42 -0800 (PST)
MIME-Version:	1.0
In-Reply-To:	<CAGRhJMYm3Hy2t6Ejkvm2hTPprQH6LwRqcqU2asJ4hBnaNASgVg@mail.gmail.com>
References:	<CAGRhJMZEWsXnVuJ_pCKqBovr71trDFD_93HCpfLaaS-h99=wxA AT mail DOT gmail DOT com>
	<CAGRhJMYm3Hy2t6Ejkvm2hTPprQH6LwRqcqU2asJ4hBnaNASgVg AT mail DOT gmail DOT com>
From:	Joshua Lansford <joshua DOT lansford AT laserlinc DOT com>
Date:	Fri, 3 Jan 2014 07:38:22 -0500
Message-ID:	<CAGRhJMZJeJukswvFup=atf=Zwfk78j0jDL4_OQZ2t4SatyQN8g@mail.gmail.com>
Subject:	[geda-user] Fwd: gnetlist silently drops components
To:	geda-user AT delorie DOT com
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

--047d7bb04050b8333a04ef103057
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Jan 2, 2014 at 8:52 AM, Joshua Lansford <
joshua DOT lansford AT laserlinc DOT com> wrote:

>
>   I just had a scare,  I was casually checking stuff into svn and noticed
> in a diffed netlist output that a component from one of our designs in
> production was missing a component.  I checked the schematic and the part
> was there all bright eyed and bushy tailed but it was completely missing
> from the generated netlist without any complaint from gnetlist.  I took a
> look at the schematic with vim and discovered I had a property missing a
> value.  I removed this valueless property and *ding* the component shows
> back up in the netlist when I run gnetlist.  Checking around some more with
> diff I discovered there was another component silently being dropped from
> the netlist.  gnetlist use to seg fault when there is a missing valued
> property.  Now apparently it silently assassinates the component.
>
> At first I thought I would just make a check script to make sure no
> components are dropped, but then I thought perhaps I might also be able to
> fix gnetlist and further this project.  But thought I would check in with
> everyone to make sure this isn't like this for a reason or perhaps has
> already been fixed.
> ~Joshua
>

The following change fixes the problem:

diff --git a/libgeda/src/o_attrib.c b/libgeda/src/o_attrib.c
index 5dae202..cb161a1 100644
--- a/libgeda/src/o_attrib.c
+++ b/libgeda/src/o_attrib.c
@@ -383,7 +383,7 @@ o_attrib_string_get_name_value (const gchar *string,
gchar **name_ptr, gchar **v
   prev_char = g_utf8_find_prev_char (string, ptr);
   next_char = g_utf8_find_next_char (ptr, NULL);
   if (prev_char == NULL || *prev_char == ' ' ||
-      next_char == NULL || *next_char == ' ' || *next_char == '\0' ) {
+      next_char == NULL || *next_char == ' ' ) {
     return FALSE;
   }


Cross posting this from gEDA-help because I never saw my posts come through.

Thanks,
~Joshua

--047d7bb04050b8333a04ef103057
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><div dir=3D"ltr"><div class=3D"=
gmail_extra"><br><div class=3D"gmail_quote"><div class=3D"im">On Thu, Jan 2=
, 2014 at 8:52 AM, Joshua Lansford <span dir=3D"ltr">&lt;<a href=3D"mailto:=
joshua DOT lansford AT laserlinc DOT com" target=3D"_blank">joshua DOT lansford AT laserlinc.=
com</a>&gt;</span> wrote:<br>


</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:s=
olid;padding-left:1ex"><div dir=3D"ltr"><div><div class=3D"im"><br><div>=A0=
 I just had a scare, =A0I was casually checking stuff into svn and noticed =
in a diffed netlist output that a component from one of our designs in prod=
uction was missing a component. =A0I checked the schematic and the part was=
 there all bright eyed and bushy tailed but it was completely missing from =
the generated netlist without any complaint from gnetlist. =A0I took a look=
 at the schematic with vim and discovered I had a property missing a value.=
 =A0I removed this valueless property and *ding* the component shows back u=
p in the netlist when I run gnetlist. =A0Checking around some more with dif=
f I discovered there was another component silently being dropped from the =
netlist. =A0gnetlist use to seg fault when there is a missing valued proper=
ty. =A0Now apparently it silently assassinates the component.</div>



<div><br></div></div><div class=3D"im"><div>At first I thought I would just=
 make a check script to make sure no components are dropped, but then I tho=
ught perhaps I might also be able to fix gnetlist and further this project.=
 =A0But thought I would check in with everyone to make sure this isn&#39;t =
like this for a reason or perhaps has already been fixed.</div>


<span><font color=3D"#888888"><div>~Joshua</div></font></span></div></div><=
/div>
</blockquote></div><br></div><div class=3D"gmail_extra">The following chang=
e fixes the problem:</div><div class=3D"gmail_extra"><br></div><div class=
=3D"gmail_extra"><div class=3D"gmail_extra">diff --git a/libgeda/src/o_attr=
ib.c b/libgeda/src/o_attrib.c</div>


<div class=3D"gmail_extra">index 5dae202..cb161a1 100644</div><div class=3D=
"gmail_extra">--- a/libgeda/src/o_attrib.c</div><div class=3D"gmail_extra">=
+++ b/libgeda/src/o_attrib.c</div><div class=3D"gmail_extra">@@ -383,7 +383=
,7 @@ o_attrib_string_get_name_value (const gchar *string, gchar **name_ptr=
, gchar **v</div>


<div class=3D"gmail_extra">=A0 =A0prev_char =3D g_utf8_find_prev_char (stri=
ng, ptr);</div><div class=3D"gmail_extra">=A0 =A0next_char =3D g_utf8_find_=
next_char (ptr, NULL);</div><div class=3D"gmail_extra">=A0 =A0if (prev_char=
 =3D=3D NULL || *prev_char =3D=3D &#39; &#39; ||</div>


<div class=3D"gmail_extra">- =A0 =A0 =A0next_char =3D=3D NULL || *next_char=
 =3D=3D &#39; &#39; || *next_char =3D=3D &#39;\0&#39; ) {</div><div class=
=3D"gmail_extra">+ =A0 =A0 =A0next_char =3D=3D NULL || *next_char =3D=3D &#=
39; &#39; ) {</div><div class=3D"gmail_extra">


=A0 =A0 =A0return FALSE;</div><div class=3D"gmail_extra">=A0 =A0}</div><div=
 class=3D"gmail_extra"><br></div><div class=3D"gmail_extra"><br></div><div =
class=3D"gmail_extra">Cross posting this from gEDA-help because I never saw=
 my posts come through.</div>

<div class=3D"gmail_extra"><div class=3D"gmail_extra"><br></div><div class=
=3D"gmail_extra">Thanks,</div><div class=3D"gmail_extra">~Joshua</div></div=
></div></div>
</div><br></div>

--047d7bb04050b8333a04ef103057--

- Raw text -