Mail Archives: geda-user/2012/11/13/02:12:24
Peter Clifton wrote:
> On Tue, 2012-11-13 at 02:53 +0100, Peter Stuge wrote:
>
>
>> I'm in favor of Bert's patch, sans the PCB_FILE_VERSION change. Would
>> you like me to fix it up and post somewhere? (Email, git: or http: ?)
>>
> I think Bert has commit access, and from the sounds of the consensus..
> we'd be all happy if he committed an amended patch.
>
> It "might" be nice to note in the parse_y.y file where the file-format
> documentation is located, that this information is not saved / used by
> PCB any more.
>
>
> At some point (presumably coinciding with another major format change),
> we might even consider removing the code to read the cursor directive.
>
> We might already be in a position where we can stub out the parsing code
> to be a NOP, and (perhaps) print a warning if the deprecated option is
> encountered.
>
> Personally.. I think not bothering with the latter is a better plan - as
> I don't want users to get warnings for _every_ existing PCB file out
> there in the world. We can worry about deprecating it later if that
> becomes desirable.
>
>
> Bert.. would you mind updating your patch to remove the file format
> version number bump, and push it to the upstream repository?
>
> Best wishes,
>
>
Hi Peter,
Amended and pushed the patch, still in the topic branch.
I let it sit there for a couple of days and if there is no comments I
push it to master.
Kind regards,
Bert Timmerman.
- Raw text -