delorie.com/archives/browse.cgi   search  
Mail Archives: geda-user/2012/05/28/17:44:35

X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=google.com; s=20120113;
h=mime-version:x-originating-ip:in-reply-to:references:from:date
:message-id:subject:to:content-type:x-gm-message-state;
bh=sBGoI4bCjwe6NkbinwTBULk6KZ46/tF495Nc1g+uytI=;
b=VWawQ0iSdxmBE85bieJZLtRKdx9xrNQe4cq3NpoH2k3zxp0q2m3/PGhxdzVjZ02kd5
RROJIltfS12Oj78Hk7119L6aSrVVKGRzEYGECqrckJidEHeX6sSSSmPzAr51k7vAuf3E
2WRg7fXo7nU4KCPfeQHb2/rfYvH/HZYr9fPqBS87aNHzB3P/Sbk993Chwl3jZTlwZI2Z
SeKWfWkLb+GL+fqEh8+d3cnhuDuSnZl3l6DJd3XfTLkoStFSYx0ayfRG0fat4yd0Erbl
AviCToTEulbkrlUFRBu+im5DfyLHVeK3uHfSVFWN50LnzJF8ZKt1SbakoO3l31JZ5mBJ
GT1w==
MIME-Version: 1.0
X-Originating-IP: [206.220.194.212]
In-Reply-To: <20120528211420.GC16992@malakian.lan>
References: <CA+DWcQYCL05epQ=APxz4DBB-0G5g+1MuvyB=p5rLeYitYX1GPg AT mail DOT gmail DOT com>
<20120528211420 DOT GC16992 AT malakian DOT lan>
From: Benjamin Bergman <ben AT benbergman DOT ca>
Date: Mon, 28 May 2012 16:43:38 -0500
Message-ID: <CA+DWcQZO+-=umy4LdB6MXnKc=uGpLp1M7k392cnigVmzGDWy2g@mail.gmail.com>
Subject: Re: [geda-user] extra mask, plating, and silk colours in pcb
To: geda-user AT delorie DOT com
X-Gm-Message-State: ALoCoQlm1hIjBzTh3ieR+J3nZnZQFEYHU+ti+esWse/9ozwD+rXot/39D5V3/8Zkc6HoYDWcBpxt
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com

--bcaec553fd6c3333e904c11f9e4d
Content-Type: text/plain; charset=ISO-8859-1

Thanks for the kind words, Andrew. I was on the gEDA IRC channel while
writing this and some of my decisions came from discussions there.


   1. We decided that, based on the weird math and the amount of tweaking
   of colour values required, using pre-programmed values seemed like the best
   option. However, I would like to add an extra 'hex' option that allows the
   user to use their own values.
   2. I have only really seen tinned plating and gold plating on commercial
   boards, so a toggle seemed fine there. I suppose a copper option might be
   nice for home etched boards. Are there any other options that should be
   added? A 'hex' mode seems less viable for plating as the gold and tin work
   in different ways in colouring the shadow and creating a texture.
   For the silk screen colours, I have only really seen black or white. I
   think I saw a yellow silk screen once, but that is not an option I've seen
   with any fab houses. I think the silk would be the simplest one to drop in
   a hex field, but don't imagine much variety will be required. If lots of
   people want it, I have no problem adding it :)


On Mon, May 28, 2012 at 4:14 PM, Andrew Poelstra <asp11 AT sfu DOT ca> wrote:

> On Mon, May 28, 2012 at 03:55:57PM -0500, Benjamin Bergman wrote:
> > Last week I was working on a project and I wanted to get my silk screen
> > looking right, but the photo-realistic options didn't match the fab
> house I
> > wanted to use, so I patched pcb to have some options. You can find the
> > patch here.  https://bugs.launchpad.net/pcb/+bug/1004796
> >
>
>
> The code is well-written and the patches are a readable size,
> which are excellent. However, I worry about the UI:
>
>  1. There are only a fixed set of colors, which limits the user, and
>     requires us (you) to hardcode color values. Maybe we want to accept
>     hex values instead?
>
>  2. What about changing the other colors? I see that you added options
>     for gold-plating and black silk (which IMHO are worthwhile special
>     cases anyway). Maybe we should accept hex values for silk and plate
>     colors as well?
>
>
> Oh, and one other thing -- take a look at "git rebase -i", which lets
> you interactively rebase and fix things like indendation without creating
> a new commit.
>
>
> > It is my first patch for pcb, so let me know if there is anything I
> should
> > improve. I imagine that marking it as affecting you will also increase
> the
> > odds of it being included into the trunk. :)
>
>
> Nope, informing the mailing list (as you did) will increase your odds :).
> Things often get missed on the bugtracker.
>
>
>
> --
> Andrew Poelstra
> Email: asp11 at sfu.ca OR apoelstra at wpsoftware.net
> Web:   http://www.wpsoftware.net/andrew
> "You shouldn't trust every quote you read on the Internet." -- Socrates
>
>

--bcaec553fd6c3333e904c11f9e4d
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Thanks for the kind words, Andrew. I was on the gEDA IRC channel while writ=
ing this and some of my decisions came from discussions there.<div><br></di=
v><div><ol><li>We decided that, based on the weird math and the amount of t=
weaking of colour values required, using pre-programmed values seemed like =
the best option. However, I would like to add an extra &#39;hex&#39; option=
 that allows the user to use their own values.</li>

<li>I have only really seen tinned plating and gold plating on commercial b=
oards, so a toggle seemed fine there. I suppose a copper option might be ni=
ce for home etched boards. Are there any other options that should be added=
? A &#39;hex&#39; mode seems less viable for plating as the gold and tin wo=
rk in different ways in colouring the shadow and creating a texture.<br>

For the silk screen colours, I have only really seen black or white. I thin=
k I saw a yellow silk screen once, but that is not an option I&#39;ve seen =
with any fab houses. I think the silk would be the simplest one to drop in =
a hex field, but don&#39;t imagine much variety will be required. If lots o=
f people want it, I have no problem adding it :)</li>

</ol><br><div class=3D"gmail_quote">On Mon, May 28, 2012 at 4:14 PM, Andrew=
 Poelstra <span dir=3D"ltr">&lt;<a href=3D"mailto:asp11 AT sfu DOT ca" target=3D"_=
blank">asp11 AT sfu DOT ca</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quo=
te" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"=
>

<div class=3D"im">On Mon, May 28, 2012 at 03:55:57PM -0500, Benjamin Bergma=
n wrote:<br>
&gt; Last week I was working on a project and I wanted to get my silk scree=
n<br>
&gt; looking right, but the photo-realistic options didn&#39;t match the fa=
b house I<br>
&gt; wanted to use, so I patched pcb to have some options. You can find the=
<br>
&gt; patch here. =A0<a href=3D"https://bugs.launchpad.net/pcb/+bug/1004796"=
 target=3D"_blank">https://bugs.launchpad.net/pcb/+bug/1004796</a><br>
&gt;<br>
<br>
<br>
</div>The code is well-written and the patches are a readable size,<br>
which are excellent. However, I worry about the UI:<br>
<br>
 =A01. There are only a fixed set of colors, which limits the user, and<br>
 =A0 =A0 requires us (you) to hardcode color values. Maybe we want to accep=
t<br>
 =A0 =A0 hex values instead?<br>
<br>
 =A02. What about changing the other colors? I see that you added options<b=
r>
 =A0 =A0 for gold-plating and black silk (which IMHO are worthwhile special=
<br>
 =A0 =A0 cases anyway). Maybe we should accept hex values for silk and plat=
e<br>
 =A0 =A0 colors as well?<br>
<br>
<br>
Oh, and one other thing -- take a look at &quot;git rebase -i&quot;, which =
lets<br>
you interactively rebase and fix things like indendation without creating<b=
r>
a new commit.<br>
<div class=3D"im"><br>
<br>
&gt; It is my first patch for pcb, so let me know if there is anything I sh=
ould<br>
&gt; improve. I imagine that marking it as affecting you will also increase=
 the<br>
&gt; odds of it being included into the trunk. :)<br>
<br>
<br>
</div>Nope, informing the mailing list (as you did) will increase your odds=
 :).<br>
Things often get missed on the bugtracker.<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
<br>
<br>
--<br>
Andrew Poelstra<br>
Email: asp11 at <a href=3D"http://sfu.ca" target=3D"_blank">sfu.ca</a> OR a=
poelstra at <a href=3D"http://wpsoftware.net" target=3D"_blank">wpsoftware.=
net</a><br>
Web: =A0 <a href=3D"http://www.wpsoftware.net/andrew" target=3D"_blank">htt=
p://www.wpsoftware.net/andrew</a><br>
&quot;You shouldn&#39;t trust every quote you read on the Internet.&quot; -=
- Socrates<br>
<br>
</font></span></blockquote></div><br></div>

--bcaec553fd6c3333e904c11f9e4d--

- Raw text -


  webmaster     delorie software   privacy  
  Copyright 2019   by DJ Delorie     Updated Jul 2019