X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-CMAE-Analysis:	v=2.4 cv=ZIsSJV3b c=1 sm=1 tr=0 ts=5fc57fd0
	a=+cj0cO56Fp8x7EdhTra87A==:117 a=rfiDQjQDpeSA6kp8Vo5lXw==:17
	a=9+rZDBEiDlHhcck0kWbJtElFXBc=:19 a=IkcTkHD0fZMA:10 a=nNwsprhYR40A:10
	a=Mj1Xp5F7AAAA:8 a=I72LuVXJ7CSJHDm7FToA:9 a=QEXdDO2ut3YA:10
	a=OCttjWrK5_uSHO_3Hkg-:22
X-SECURESERVER-ACCT:	glimrick AT epilitimus DOT com
Subject:	Re: [geda-user] SAB processing patches
To:	geda-user AT delorie DOT com
References:	<e4ff3c96-939b-a93e-a32f-5e938b6daa63 AT epilitimus DOT com>
	<alpine DOT DEB DOT 2 DOT 21 DOT 2011302045040 DOT 2894 AT nimbus>
	<20201130220505 DOT 0AE4282C54FD AT turkos DOT aspodata DOT se>
From:	"Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Message-ID:	<7c75ed03-456c-b408-8b50-0448f6b3a04f@epilitimus.com>
Date:	Mon, 30 Nov 2020 15:26:59 -0800
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
	Firefox/60.0 SeaMonkey/2.53.3
MIME-Version:	1.0
In-Reply-To:	<20201130220505.0AE4282C54FD@turkos.aspodata.se>
X-AntiAbuse:	This header was added to track abuse, please include it with any abuse report
X-AntiAbuse:	Primary Hostname - a2plcpnl0121.prod.iad2.secureserver.net
X-AntiAbuse:	Original Domain - delorie.com
X-AntiAbuse:	Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse:	Sender Address Domain - epilitimus.com
X-Get-Message-Sender-Via:	a2plcpnl0121.prod.iad2.secureserver.net: authenticated_id: glimrick AT epilitimus DOT com
X-Authenticated-Sender:	a2plcpnl0121.prod.iad2.secureserver.net: glimrick AT epilitimus DOT com
X-Source:
X-Source-Args:
X-Source-Dir:
X-CMAE-Envelope:	MS4xfNwFUHD+BTl2n8Q9Y0QLG28w8zrP8lHc1HyWnXRhkwmbZ7IYv+qRDoroYURUU/tn6ihjjh7JLzf7uS587w58C0bLk/tE4CA9j4Hy02B9eBHfMzxC5S/c
	OD9oujoxYpRy98hTOUHMnh1pZ3LpLZXiTq4ewW8juaRcnbQ4PpgzH69/vAFVSUdHEXnq7aeIcBY/i8VbiGIPnqyAXdlZC+3XOJYs83lsuMfvk0A79x9fk5IR
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Karl,
Actually there is one in the HACKING file, I just forgot to use it
before generating the patches.
Glenn

Roland,
Old habits die hard :)
G

karl AT aspodata DOT se [via geda-user AT delorie DOT com] wrote:
> Roland Lutz:
> ...
>> >From a first glance, this looks good.  I'll have to go through the patches 
>> and understand how they work in detail in order to say anything 
>> substantiated, but there's some formal things I noticed when skimming 
>> through:
>>
>> - Functions which are only used inside the file in which they are defined 
>> should be "static" (not visible in the global namespace).
>>
>> - New C code should follow the C coding style of the project:
>>    - two spaces indentation,
>>    - one space character before a parameter list(!) and before and after an
>>      operator, and before (but not after) a pointer asterisk,
>>    - the opening brace goes on the same line for control structures but on
>>      a separate line for function headers.
>>    Code on one level of indentation should always be indented consistently.
> ...
>> - Lines in source and text files should be less than 80 characters long. 
>> Lines in commit messages should not be longer than 72 characters, and (if 
>> one feels pedantic) 64 characters on the first line.
> ...
>
> Why not provide a recipy for the program "indent", and be done with it.
>
> Regards,
> /Karl Hammar
>
>
>

- Raw text -