X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
Date:	Mon, 13 Mar 2017 09:34:35 +0100 (CET)
X-X-Sender:	igor2 AT igor2priv
To:	geda-user AT delorie DOT com
X-Debug:	to=geda-user AT delorie DOT com from="gedau AT igor2 DOT repo DOT hu"
From:	gedau AT igor2 DOT repo DOT hu
Subject:	[geda-user] [pcb] [dev] misfeature/bug report: fontmode, a.k.a. fontedit() is
	editing the wrong font
Message-ID:	<alpine.DEB.2.00.1703130921040.27212@igor2priv>
User-Agent:	Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version:	1.0
Reply-To:	geda-user AT delorie DOT com

Hi pcb devs,

I'm upgrading the fontmode code in pcb-rnd to handle our new multi-font 
setup. While doing so, I figured there is a bug (or at best misfeature) 
sitting in there, perhaps right from the beginning.

When the font editor is started, it first creates a new board, then 
loads/converts the font. This means if the user has replaced the font in a 
pcb, the font editor will still edit the default font. The only way to 
edit any non-default font is probably to make it the default font for some 
time (may need root privileges and may interfere with other users' 
activity on a multiuser system).

For reference, fixed in pcb-rnd in r7648 and r7650 (but I don't think this 
patch is compatible with mainline).

For a short time I though it was all by design, so that the font editor 
is really the editor of the default font exclusively. But then I took a 
look at how the edited font is supposed to hit the disk and that convinced 
me that's not the case.

I also have doubt about the usability of action FontSave() in general. It 
seems to pack the result back into the current pcb's font - which is the 
font-editor-dummy-pcb. What's the intended method for saving the font to a 
file? Save the dummy pcb, then cut it out with a text editor?

Regards,

Igor2

- Raw text -