Mail Archives: geda-user/2016/01/17/16:51:25
This is a multi-part message in MIME format.
--------------010603070502080006000001
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
On 17/01/16 21:34, Britton Kerin (britton DOT kerin AT gmail DOT com) [via
geda-user AT delorie DOT com] wrote:
>
>
> On Sun, Jan 17, 2016 at 8:16 AM, M. J. Everitt (m DOT j DOT everitt AT iee DOT org
> <mailto:m DOT j DOT everitt AT iee DOT org>) [via geda-user AT delorie DOT com
> <mailto:geda-user AT delorie DOT com>] <geda-user AT delorie DOT com
> <mailto:geda-user AT delorie DOT com>> wrote:
>
>
> On 17/01/16 17:08, Milan Prochac (milan AT prochac DOT sk
> <mailto:milan AT prochac DOT sk>) [via
> geda-user AT delorie DOT com <mailto:geda-user AT delorie DOT com>] wrote:
> > On 17. 1. 2016 13:24, Peter Clifton
> (petercjclifton AT googlemail DOT com <mailto:petercjclifton AT googlemail DOT com>)
> > [via geda-user AT delorie DOT com <mailto:geda-user AT delorie DOT com>] wrote:
> >> No // comments please.
> >>
> >
> > Well, but they seems to be quite common:
> >
> > $ git status
> > # On branch master
> > nothing to commit, working directory clean
> > $ grep -R // * | grep // | wc -l
> > 527
> >
> > Milan
> >
> Better to have some QA scripts that pick these things out, than use
> compiler options. Even better still, use commit hooks to run these
> scripts so that you cannot commit without fixing any issues.
>
>
> Even better would be to ignore them, since they aren't really issues.
> It's window dressing, you might put it on after everything else is
> perfect, which is not the case here. Putting it on fixes nothing real.
>
> A number of devels don't actually like the current preferred style,
> but want to continue using it perhaps out of respect for the original
> devels. Who aren't even around any more.
>
> Indentation matters, local consistency matters, // vs /* and which
> line braces go on don't.
>
> Britton
Totally in agreement .. food for the 'coding standard' debate that's
floating around .. what would people 'prefer' was the 'right' way?!
--------------010603070502080006000001
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 17/01/16 21:34, Britton Kerin
(<a class="moz-txt-link-abbreviated" href="mailto:britton DOT kerin AT gmail DOT com">britton DOT kerin AT gmail DOT com</a>) [via <a class="moz-txt-link-abbreviated" href="mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>] wrote:<br>
</div>
<blockquote
cite="mid:CAC4O8c9_kMdr+3xhe4-CZvUxPGzgqBrLN=Kn+WdGqGVcV1Nbnw AT mail DOT gmail DOT com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sun, Jan 17, 2016 at 8:16 AM, M.
J. Everitt (<a moz-do-not-send="true"
href="mailto:m DOT j DOT everitt AT iee DOT org">m DOT j DOT everitt AT iee DOT org</a>)
[via <a moz-do-not-send="true"
href="mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>]
<span dir="ltr"><<a moz-do-not-send="true"
href="mailto:geda-user AT delorie DOT com" target="_blank">geda-user AT delorie DOT com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On 17/01/16 17:08, Milan Prochac (<a
moz-do-not-send="true" href="mailto:milan AT prochac DOT sk">milan AT prochac DOT sk</a>)
[via<br>
<div>
<div class="h5"><a moz-do-not-send="true"
href="mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>]
wrote:<br>
> On 17. 1. 2016 13:24, Peter Clifton (<a
moz-do-not-send="true"
href="mailto:petercjclifton AT googlemail DOT com">petercjclifton AT googlemail DOT com</a>)<br>
> [via <a moz-do-not-send="true"
href="mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>]
wrote:<br>
>> No // comments please.<br>
>><br>
><br>
> Well, but they seems to be quite common:<br>
><br>
> $ git status<br>
> # On branch master<br>
> nothing to commit, working directory clean<br>
> $ grep -R // * | grep // | wc -l<br>
> 527<br>
><br>
> Milan<br>
><br>
</div>
</div>
Better to have some QA scripts that pick these things out,
than use<br>
compiler options. Even better still, use commit hooks to
run these<br>
scripts so that you cannot commit without fixing any
issues.<br>
</blockquote>
<div><br>
</div>
<div style="">Even better would be to ignore them, since
they aren't really issues. It's window dressing, you
might put it on after everything else is perfect, which is
not the case here. Putting it on fixes nothing real.</div>
<div style=""><br>
</div>
<div style="">A number of devels don't actually like the
current preferred style, but want to continue using it
perhaps out of respect for the original devels. Who
aren't even around any more.</div>
<div style=""><br>
</div>
<div style="">Indentation matters, local consistency
matters, // vs /* and which line braces go on don't.</div>
<div style=""><br>
</div>
<div style="">Britton</div>
</div>
</div>
</div>
</blockquote>
Totally in agreement .. food for the 'coding standard' debate that's
floating around .. what would people 'prefer' was the 'right' way?!<br>
</body>
</html>
--------------010603070502080006000001--
- Raw text -