delorie.com/archives/browse.cgi | search |
X-Authentication-Warning: | delorie.com: mail set sender to geda-user-bounces using -f |
X-Recipient: | geda-user AT delorie DOT com |
X-Original-DKIM-Signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; |
d=gmail.com; s=20120113; | |
h=mime-version:in-reply-to:references:date:message-id:subject:from:to | |
:content-type; | |
bh=t7dSRICHLmf6BOIWfpi/2Bnywunt3TacXvcWm3GbGTg=; | |
b=Hr7yTe/goh4neZ2av6eoKNjIxKXus0lC+cKKUsQTtXeadQPcJnj+vH00vSSf6NRFLZ | |
MloGsgdbOQ6a/mpKgWSRrhMTeZLH1TrrlDaqt+gJaR41FFvVAhFh2hscHuTOfISKUCsX | |
Jgbc2SbWo6JKAmwvWKf8iZckbUfttUF1YGw54tcvfKtUxICbBTUVXsyZngmyR9sjQOpJ | |
G7y5wfknSIouSUdXcAJclH6jbYu9LObn4aHIANDZjwNVUziisgrojVesvbwzC9/ZTKfx | |
1Q3P9SdqC1KT7OEu1LxS6HG//KArtNR+sggpil//lCeqqV11NRqz+q4nBwPwC37zsZ+C | |
et4g== | |
X-Google-DKIM-Signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; |
d=1e100.net; s=20130820; | |
h=x-gm-message-state:mime-version:in-reply-to:references:date | |
:message-id:subject:from:to:content-type; | |
bh=t7dSRICHLmf6BOIWfpi/2Bnywunt3TacXvcWm3GbGTg=; | |
b=DGwtFPS7BHhlpgG1Au8ikM0sP+IqZAjFxHucBXmfj5atq4iyrEgsrszsAFcm2Kn8k/ | |
vfCzM9/Zu8nDmNnT16z4pSaAuVVwNaff7ywXuT+CEPdXanEjPlsWjpPlJ4QXVVBUvmgR | |
cmqw3lMMv/B+pY2oEGr6RL1lLdk77xTkwTfioehdmdjr7/LgZBk2pUV7GA28Ttj7w8Em | |
5KSZH4zM/LknWsIUhNealGc6LTbQsCwWne2U14M0TD80N8D8R9wOyjmbHi1usHoujp5n | |
CPvwNpc8EfYEULPsfmWSmh+N7BoMWTg85OKCE8bzrjtAPqrcUIFwZX8aYwTKOEm+KLPN | |
l78A== | |
X-Gm-Message-State: | AG10YOQZ3s7RDGrfcHOQbauWM+pUAzgSGR3Cw3QhLwJ1991aVpj/2aCE3y0lpOYhdE/4JXpf86QsUVa3F/7PEg== |
MIME-Version: | 1.0 |
X-Received: | by 10.28.48.131 with SMTP id w125mr9091748wmw.18.1453066476413; |
Sun, 17 Jan 2016 13:34:36 -0800 (PST) | |
In-Reply-To: | <569BCC77.60700@iee.org> |
References: | <CAC4O8c88EnAJ1H4YL4rj2O10ihZAz_NYDMSBAWEmdknMNu2b4A AT mail DOT gmail DOT com> |
<CAJXU7q8AtP=UOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA AT mail DOT gmail DOT com> | |
<569BCA7F DOT 70903 AT prochac DOT sk> | |
<569BCC77 DOT 60700 AT iee DOT org> | |
Date: | Sun, 17 Jan 2016 12:34:36 -0900 |
Message-ID: | <CAC4O8c9_kMdr+3xhe4-CZvUxPGzgqBrLN=Kn+WdGqGVcV1Nbnw@mail.gmail.com> |
Subject: | Re: [geda-user] cleaner version of fixes to file format plugin |
From: | "Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com> |
To: | geda-user AT delorie DOT com |
Reply-To: | geda-user AT delorie DOT com |
Errors-To: | nobody AT delorie DOT com |
X-Mailing-List: | geda-user AT delorie DOT com |
X-Unsubscribes-To: | listserv AT delorie DOT com |
--001a114242a4296dac05298e674e Content-Type: text/plain; charset=UTF-8 On Sun, Jan 17, 2016 at 8:16 AM, M. J. Everitt (m DOT j DOT everitt AT iee DOT org) [via geda-user AT delorie DOT com] <geda-user AT delorie DOT com> wrote: > > On 17/01/16 17:08, Milan Prochac (milan AT prochac DOT sk) [via > geda-user AT delorie DOT com] wrote: > > On 17. 1. 2016 13:24, Peter Clifton (petercjclifton AT googlemail DOT com) > > [via geda-user AT delorie DOT com] wrote: > >> No // comments please. > >> > > > > Well, but they seems to be quite common: > > > > $ git status > > # On branch master > > nothing to commit, working directory clean > > $ grep -R // * | grep // | wc -l > > 527 > > > > Milan > > > Better to have some QA scripts that pick these things out, than use > compiler options. Even better still, use commit hooks to run these > scripts so that you cannot commit without fixing any issues. > Even better would be to ignore them, since they aren't really issues. It's window dressing, you might put it on after everything else is perfect, which is not the case here. Putting it on fixes nothing real. A number of devels don't actually like the current preferred style, but want to continue using it perhaps out of respect for the original devels. Who aren't even around any more. Indentation matters, local consistency matters, // vs /* and which line braces go on don't. Britton --001a114242a4296dac05298e674e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo= te">On Sun, Jan 17, 2016 at 8:16 AM, M. J. Everitt (<a href=3D"mailto:m.j.e= veritt AT iee DOT org">m DOT j DOT everitt AT iee DOT org</a>) [via <a href=3D"mailto:geda-user AT d= elorie.com">geda-user AT delorie DOT com</a>] <span dir=3D"ltr"><<a href=3D"mai= lto:geda-user AT delorie DOT com" target=3D"_blank">geda-user AT delorie DOT com</a>><= /span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8= ex;border-left:1px #ccc solid;padding-left:1ex"><br> On 17/01/16 17:08, Milan Prochac (<a href=3D"mailto:milan AT prochac DOT sk">milan= @prochac.sk</a>) [via<br> <div><div class=3D"h5"><a href=3D"mailto:geda-user AT delorie DOT com">geda-user AT d= elorie.com</a>] wrote:<br> > On 17. 1. 2016 13:24, Peter Clifton (<a href=3D"mailto:petercjclifton@= googlemail.com">petercjclifton AT googlemail DOT com</a>)<br> > [via <a href=3D"mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a= >] wrote:<br> >> No // comments please.<br> >><br> ><br> > Well, but they seems to be quite common:<br> ><br> > $ git status<br> > # On branch master<br> > nothing to commit, working directory clean<br> > $ grep -R // * | grep // | wc -l<br> > 527<br> ><br> > Milan<br> ><br> </div></div>Better to have some QA scripts that pick these things out, than= use<br> compiler options. Even better still, use commit hooks to run these<br> scripts so that you cannot commit without fixing any issues.<br></blockquot= e><div><br></div><div style=3D"">Even better would be to ignore them, since= they aren't really issues.=C2=A0 It's window dressing, you might p= ut it on after everything else is perfect, which is not the case here.=C2= =A0 Putting it on fixes nothing real.</div><div style=3D""><br></div><div s= tyle=3D"">A number of devels don't actually like the current preferred = style, but want to continue using it perhaps out of respect for the origina= l devels.=C2=A0 Who aren't even around any more.</div><div style=3D""><= br></div><div style=3D"">Indentation matters, local consistency matters, //= vs /* and which line braces go on don't.</div><div style=3D""><br></di= v><div style=3D"">Britton</div></div></div></div> --001a114242a4296dac05298e674e--
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |