X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; c=simple; d=mail.ud03.udmedia.de; h=
	subject:to:references:from:message-id:date:mime-version
	:in-reply-to:content-type:content-transfer-encoding; s=beta; bh=
	gUxRYMD3tB4Jk6q8OTNt5baMJHX79lqC66ik8q6MlFk=; b=mtpLyZOcXdLwUC70
	ExxnTeAFxFp1P0vt78ZxrY6kzDtrE77KQo4tsR2ETIpbolu9t2m7bYmGoScEG4hS
	rUXyVICNAU5+5gyTxbeAcuK4h13yRNscUCvkdwvyVHkSfdQisdl+FZuwc0m+XOXx
	Dz/QI5BQCGtwnoOg249f2dE42QY=
Subject:	Re: [geda-user] How to fix gerbv to compile with gcc5?
To:	geda-user AT delorie DOT com
References:	<20151006115833 DOT GA6570 AT visitor2 DOT iram DOT es>
From:	"Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
X-Enigmail-Draft-Status:	N1110
Message-ID:	<5613C2EC.7080900@jump-ing.de>
Date:	Tue, 6 Oct 2015 14:47:40 +0200
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.2.0
MIME-Version:	1.0
In-Reply-To:	<20151006115833.GA6570@visitor2.iram.es>
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Am 06.10.2015 um 13:58 schrieb Gabriel Paubert:

> This is a very simple patch, but you
> don't get the advantages of inlining.

Thanks for the patch, Gabriel. AFAIK functions from other compilation
units are never inlined, unless a relatively new technology named LTO
(link time optimisation) enters the picture.

Even then, gcc is quite good at inlining automatically, so using
'inline' at all is pretty moot. Exception are function definitions (not
declarations) in header files, which work with 'inline', only.


> Anyaway here is the patch I have rigt now in my tree, disregard the "#if 0" 
> for [...]

Yes, a patch with a bit more love (tidiness) applied would be nice and
making the patch from a Git commit would also put your credentials into
the repo. No need to hide your contribution.


Markus

-- 
- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/

- Raw text -