delorie.com/archives/browse.cgi | search |
X-Authentication-Warning: | delorie.com: mail set sender to geda-user-bounces using -f |
X-Recipient: | geda-user AT delorie DOT com |
X-Original-DKIM-Signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; |
d=gmail.com; s=20120113; | |
h=date:from:to:subject:message-id:mail-followup-to:references | |
:mime-version:content-type:content-disposition:in-reply-to | |
:user-agent; | |
bh=HkLILlzUBmpyoXbrkDg9Vh8qVdkCFx0uzGWGQ5G0zB0=; | |
b=rtusXW7nT+A8Zui2c1aWhADdB3IAABQErUR+aNd0HFF1rPGk2cV/opok6EgozytCke | |
NY/tuGk1urlsA/+uX4JJ7x81/kPtBhdENamOrPS6jxoAyjS16ATZp4EkX39nyYg3rJnp | |
430h3jfuBcDtPjuN1teH3gMDbP1LOFR4ZeHKoPNC1J7G+qjwhX01jPwTAvvb2r8I/DwO | |
/FsxLa0mHYlqbZFX1i0bIDDClwIJRg1A5vNwPpYhbOSjTSHlGI+EIXRubqP91RObYxbB | |
AidHx5pJgpuqFm94SU1lNpLCpEiBlAC48NHZOTPgp3/kizKHf4jOgtAX+gIWe3m5Mh7P | |
v8cg== | |
X-Received: | by 10.112.56.139 with SMTP id a11mr21575364lbq.90.1436561723937; |
Fri, 10 Jul 2015 13:55:23 -0700 (PDT) | |
Date: | Fri, 10 Jul 2015 23:55:21 +0300 |
From: | "Vladimir Zhbanov (vzhbanov AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com> |
To: | geda-user AT delorie DOT com |
Subject: | Re: [geda-user] building gEDA |
Message-ID: | <20150710205521.GA15123@localhost.localdomain> |
Mail-Followup-To: | geda-user AT delorie DOT com |
References: | <20150710214448 DOT 2cac813e AT jive DOT levalinux DOT org> |
MIME-Version: | 1.0 |
In-Reply-To: | <20150710214448.2cac813e@jive.levalinux.org> |
User-Agent: | Mutt/1.5.23 (2014-03-12) |
Reply-To: | geda-user AT delorie DOT com |
Errors-To: | nobody AT delorie DOT com |
X-Mailing-List: | geda-user AT delorie DOT com |
X-Unsubscribes-To: | listserv AT delorie DOT com |
On Fri, Jul 10, 2015 at 09:44:48PM +0200, Lev (leventelist AT gmail DOT com) [via geda-user AT delorie DOT com] wrote: > Okay, this has been said before. I tried to build gEDA on FreeBSD, and > it was not possible out of the box. The problem was the same, when I > last tried. I see the same problems over and over again. > > I'm sorry to say this, but I'd like to kindly ask developers not to make the > same coding errors again. > > Patch attached. I can file bug report, or I can reopen the previous one. > > It is about the usage of g_return_if_fail() and g_return_val_if_fail(). > > Basically, if the function returns void, g_return_if_fail() shall be used. > Otherwise g_return_val_if_fail(), and you should supply a return value that > makes sense. In my patch I used 'NULL' but I didn't really checked the return > type of the functions, so my patch must be reviewed before commit. > > Affected files: > > gschem/src/gschem_options_dialog.c > gschem/src/o_bus.c > gschem/src/x_grid.c > > > The other thing is the inline sed script in > > build-tools/icon-theme-installer > > - install_name=`echo $build_name | sed 's/-[0-9]\+//g'` > + install_name=`echo $build_name | sed 's/-[0-9][0-9]*//g'` > > It would be very nice, if I (and other FreeBSD/OS-X, clang, non-Linux users) > could build gschem out of the box, without editing the source code. It is > okay, if something new comes up, I am more than happy to send patches. > > Is this okay, that the build process overwrites all the po files? My patch > looks ugly. > Hi, Lev. Is this bug report not yours? https://launchpadlibrarian.net/211317303/0001-Fix-FreeBSD-build-and-install-errors.patch 8-0 Probably today is the day of FreeBSD users activity (looking at the moon). I've looked into the build-tools/icon-theme-installer. It was last changed in 2011. And that recently solved issue with sed was in gschem/icon-theme-installer. %/ I wonder, did you build geda since 2011? Cheers, Vladimir
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |