X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=gmail.com; s=20120113;
	h=date:from:to:subject:message-id:mail-followup-to:references
	:mime-version:content-type:content-disposition:in-reply-to
	:user-agent;
	bh=dJntG99ToEVAs3f837p5cvQPov1Q5Z3xBPchB4x+crY=;
	b=aTKve5BYHTMlttYFFV1MVX/7wHnEqDH3KRLOUUIyVV5607100FHJOGZqHMCdM3UQO+
	N0nayp7sq3FX9hgEKrCgxXpJHnT6k9fseF4XcU6xwg9+3qNKqlmI9yjR2+jbxHgKPbzN
	WAmn6VhDrzgqURDJTgyvBA+4rxu5RvTAdeBKRFqW8Dy06t1V6aSgtXrielE55BOIsOdB
	PdxTEZ/QPd5OC5JufwtUEPJmkB520GXMMVmpivjVUIliEAvMmekEPDUIYqxoZgIO+WX7
	8ot/bNK6ofxSZARbGprIZdcd9AV6cSqEwVl/zUP3+wZJODMU5tEUMkE+OhRRu4OJre/4
	Hrgg==
X-Received:	by 10.152.225.161 with SMTP id rl1mr6367465lac.5.1387636373005;
	Sat, 21 Dec 2013 06:32:53 -0800 (PST)
Date:	Sat, 21 Dec 2013 18:32:49 +0400
From:	Vladimir Zhbanov <vzhbanov AT gmail DOT com>
To:	geda-user AT delorie DOT com
Subject:	Re: [geda-user] [PATCH] Customizable graphical elements
Message-ID:	<20131221143249.GA31097@localhost.localdomain>
Mail-Followup-To:	geda-user AT delorie DOT com
References:	<20131213050140 DOT 4ae1f52c AT warrawoona DOT sti>
MIME-Version:	1.0
In-Reply-To:	<20131213050140.4ae1f52c@warrawoona.sti>
User-Agent:	Mutt/1.5.21 (2010-09-15)
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Hi, Alexey.

First, thank you for your work.

FYI, the right place for patches is now launchpad.net/geda.
Please fill the bug report there. Patches in the mailing list tend
to be lost.  Besides, it would be nice if you provide us with a
sample geda.conf file.

Now, my thoughts about your patch.

The patch contains many unnecessary space changes obfuscating
the changes really made.  If you want to make any space changes
please do them in a separate patch and according to the HACKING
document. You can find the document in the root directory of the
geda-gaf repository. It has a special mention of whitespace
changes. It also reads you must not use tabs; use two spaces
indentations instead.

IMO, the part with buses should be made as a separate patch.  Your
vision of buses may not be applicable to all. For instance, how to
distinguish the case where buses don't connect and just cross one
another?  I think the way buses are displayed should be at least
configurable.

Too many TODO's :)
I think you should not call eda_config_get_context_for_file every
time gschem creates an object. It is an initialization function
and it should be called once at the init step.  I'm in doubt you
should use it at all.  Just try to set your variables in geda.conf
to big values for a local project schematic, run gschem, add
something, and delete the geda.conf file during the work. You will
watch some strange special effects you did not apparently expect.

Regards,
  Vladimir

- Raw text -