delorie.com/archives/browse.cgi | search |
On Tue, 2012-11-13 at 02:53 +0100, Peter Stuge wrote: > I'm in favor of Bert's patch, sans the PCB_FILE_VERSION change. Would > you like me to fix it up and post somewhere? (Email, git: or http: ?) I think Bert has commit access, and from the sounds of the consensus.. we'd be all happy if he committed an amended patch. It "might" be nice to note in the parse_y.y file where the file-format documentation is located, that this information is not saved / used by PCB any more. At some point (presumably coinciding with another major format change), we might even consider removing the code to read the cursor directive. We might already be in a position where we can stub out the parsing code to be a NOP, and (perhaps) print a warning if the deprecated option is encountered. Personally.. I think not bothering with the latter is a better plan - as I don't want users to get warnings for _every_ existing PCB file out there in the world. We can worry about deprecating it later if that becomes desirable. Bert.. would you mind updating your patch to remove the file format version number bump, and push it to the upstream repository? Best wishes, -- Peter Clifton <peter DOT clifton AT clifton-electronics DOT co DOT uk> Clifton Electronics
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |