delorie.com/archives/browse.cgi   search  
Mail Archives: geda-user/2012/11/12/21:38:30

X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Cam-AntiVirus: no malware found
X-Cam-SpamDetails: not scanned
X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/
Message-ID: <1352774294.9720.11.camel@localhost>
Subject: Re: [geda-user] RFC: storing cursor position in PCB files
From: Peter Clifton <pcjc2 AT cam DOT ac DOT uk>
To: geda-user AT delorie DOT com
Date: Tue, 13 Nov 2012 02:38:14 +0000
In-Reply-To: <20121113015303.2988.qmail@stuge.se>
References: <508BBF8D DOT 5070309 AT jump-ing DOT de> <509B51BE DOT 3010203 AT xs4all DOT nl>
<alpine DOT DEB DOT 2 DOT 00 DOT 1211081144590 DOT 25985 AT igor2priv>
<509C7380 DOT 2090008 AT ecosensory DOT com> <1352749309 DOT 10421 DOT 15 DOT camel AT localhost>
<20121113002422 DOT 27378 DOT qmail AT stuge DOT se> <1352770711 DOT 9720 DOT 6 DOT camel AT localhost>
<20121113015303 DOT 2988 DOT qmail AT stuge DOT se>
X-Mailer: Evolution 3.6.0-0ubuntu3
Mime-Version: 1.0
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com

On Tue, 2012-11-13 at 02:53 +0100, Peter Stuge wrote:

> I'm in favor of Bert's patch, sans the PCB_FILE_VERSION change. Would
> you like me to fix it up and post somewhere? (Email, git: or http: ?)

I think Bert has commit access, and from the sounds of the consensus..
we'd be all happy if he committed an amended patch.

It "might" be nice to note in the parse_y.y file where the file-format
documentation is located, that this information is not saved / used by
PCB any more.


At some point (presumably coinciding with another major format change),
we might even consider removing the code to read the cursor directive.

We might already be in a position where we can stub out the parsing code
to be a NOP, and (perhaps) print a warning if the deprecated option is
encountered.

Personally.. I think not bothering with the latter is a better plan - as
I don't want users to get warnings for _every_ existing PCB file out
there in the world. We can worry about deprecating it later if that
becomes desirable.


Bert.. would you mind updating your patch to remove the file format
version number bump, and push it to the upstream repository?

Best wishes,

-- 
Peter Clifton <peter DOT clifton AT clifton-electronics DOT co DOT uk>

Clifton Electronics


- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019