X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
Message-ID:	<20121113015303.2988.qmail@stuge.se>
Date:	Tue, 13 Nov 2012 02:53:03 +0100
From:	Peter Stuge <peter AT stuge DOT se>
To:	geda-user AT delorie DOT com
Subject:	Re: [geda-user] RFC: storing cursor position in PCB files
Mail-Followup-To:	geda-user AT delorie DOT com
References:	<508BBF8D DOT 5070309 AT jump-ing DOT de> <509B51BE DOT 3010203 AT xs4all DOT nl> <alpine DOT DEB DOT 2 DOT 00 DOT 1211081144590 DOT 25985 AT igor2priv> <509C7380 DOT 2090008 AT ecosensory DOT com> <1352749309 DOT 10421 DOT 15 DOT camel AT localhost> <20121113002422 DOT 27378 DOT qmail AT stuge DOT se> <1352770711 DOT 9720 DOT 6 DOT camel AT localhost>
MIME-Version:	1.0
In-Reply-To:	<1352770711.9720.6.camel@localhost>
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Peter Clifton wrote:
> > > > >> I filed this as bug report https://bugs.launchpad.net/pcb/+bug/1076252
> > > 
> > > Someone send a patch to remove saving this line in the output file,
> > > and I'll gladly commit it.
> > 
> > Bert has attached a patch to the bug, along with a branch reference:
> > 
> > git://git.geda-project.org/pcb.git LP1076252
> 
> Sorry, I'd missed that..

Don't worry, it was minutes old when I sent my email.


> > But: Does PCB_FILE_VERSION actually have to change?
> 
> No, it does not. (IMO)

I agree.


> The patch doesn't actually remove the cursor directive from the file
> format, it just stops it being saved out.

Ack.


> > And: What is the cursor initialized to when reading a file without Cursor?
> 
> Untested, but I think zero.

Sounds good.


> HOWEVER..
> 
> I note that the cursor directive restores the default zoom of a given
> PCB file. Removing this line will stop PCB saving the view's zoom state.
> 
> Personally, I think this isn't an issue - especially since when I just
> tested now, it did not correctly restore any view settings.

Even if it would, I think it's OK to take one step backward (remove
zoom from files) in order to take two steps forward a little later!

I'm in favor of Bert's patch, sans the PCB_FILE_VERSION change. Would
you like me to fix it up and post somewhere? (Email, git: or http: ?)


//Peter

- Raw text -