X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
DKIM-Signature:	v=1; a=rsa-sha256; c=simple; d=mail.ud03.udmedia.de; h=
	mime-version:in-reply-to:references:content-type:message-id
	:content-transfer-encoding:from:subject:date:to; s=beta; bh=Jc2k
	Ybt4T+d96YRNZjEE+/0O9I3KCO82aHw3ZTrUd7w=; b=KVarv77QZaslMGhmjuNd
	XIu3Gg/SjAQjWhFTvvogNUj6j9y+s7jQAodRMtETh20pBuokx3NVRu1cJkVFVFk1
	1esf8xWEZwr2jnklQTKWGxPtqBlliC4N8+qeBnzru8rykFpTOe1AOEb+daC8FD18
	fdkLrL9VPOz3FYScgAXKXdM=
Mime-Version:	1.0 (Apple Message framework v753.1)
In-Reply-To:	<20120903232403.GA19048@recycle.lbl.gov>
References:	<20120903232403 DOT GA19048 AT recycle DOT lbl DOT gov>
Message-Id:	<753C3E35-FAE8-4650-B80C-E8478DBE44FD@jump-ing.de>
From:	Markus Hitter <mah AT jump-ing DOT de>
Subject:	Re: [geda-user] pcbdiff
Date:	Tue, 4 Sep 2012 15:10:21 +0200
To:	geda-user AT delorie DOT com
X-Mailer:	Apple Mail (2.753.1)
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Am 04.09.2012 um 01:24 schrieb Larry Doolittle:

> I messed around some with pcbdiff.  When it works, it's really nice!
> But I had problems with the image sizes mismatching between versions,
> even though the actual board size didn't change.  Those problems went
> away when I took out the --only-visible flag.
>
> While I was in there, I made the 200 dpi default over-ride-able with
> the environment variable PCBDIFF_DPI.  Patch attached.

Hello Larry,

first, thanks for the patch. Could you please open a bug on  
Launchpad, adding this patch and your test case? At the first glance  
I'm not sure wether this is the right fix, it might be a better idea  
to fix the reason for the differently sized PNG exports.


Markus

- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/

- Raw text -