X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
Date:	Fri, 6 Jul 2012 09:55:05 -0700
From:	Andrew Poelstra <asp11 AT sfu DOT ca>
To:	geda-user AT delorie DOT com
Subject:	[geda-user] BOM test failure (was: [PATCH] Allow to create metric
	Gerber and drill files.)
Message-ID:	<20120706165505.GE24386@malakian.lan>
References:	<20120703140236 DOT GA12646 AT visitor2 DOT iram DOT es>
	<CAKakQcdTgG6E2h+UgWoh-ujP6vFDH=voY-PBJR3OFG2awqL0_A AT mail DOT gmail DOT com>
	<20120705101614 DOT GA19974 AT visitor2 DOT iram DOT es>
	<20120705173423 DOT GC12804 AT malakian DOT lan>
	<20120706090636 DOT GA22475 AT visitor2 DOT iram DOT es>
	<20120706162806 DOT GD24386 AT malakian DOT lan>
MIME-Version:	1.0
In-Reply-To:	<20120706162806.GD24386@malakian.lan>
User-Agent:	Mutt/1.5.20 (2009-12-10)
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On Fri, Jul 06, 2012 at 09:28:06AM -0700, Andrew Poelstra wrote:
> 
> No, I'm sure they're not. As I recall, there was some minor
> reordering in the BOM exporter, hence the test breaking. But
> I also recall the tests being fixed...perhaps I should take a
> look at that.
>

git bisect shows the breakage "happened" with

commit a34b5d9ff0851ca54546263b9f06c84cf78854a1
Author: Dima Kogan <dima AT secretsauce DOT net>
Date:   Sun Nov 13 16:20:32 2011 -0800

    fixed broken bom, xy and gcode testing
    
    I was comparing the reference files to themselves. Now comparing reference and test files



That is, the tests started failing an indeterminate amount of time ago,
and we only just noticed recently because the testing code was broken.

This'll be fun to track down... ;)


-- 
Andrew Poelstra
Email: asp11 at sfu.ca OR apoelstra at wpsoftware.net
Web:   http://www.wpsoftware.net/andrew
"You shouldn't trust every quote you read on the Internet." -- Socrates

- Raw text -