Mail Archives: djgpp/2003/06/17/21:30:26
Hans-Bernhard Broeker <broeker AT physik DOT rwth-aachen DOT de> writes:
>In article <bcm2d0$6c6$1 AT blue DOT rahul DOT net> you wrote:
>> --- filefn.cpp.ori 2003-05-15 01:37:58.000000000 -0700
>> +++ filefn.cpp 2003-06-16 20:03:28.000000000 -0700
>> @@ -173,6 +173,7 @@
>> return(1457664);
>> #elif defined(_EMX)
>> int Drive=(!isalpha(FileName[0]) || FileName[1]!=':') ? 0:toupper(FileName[0])-'A'+1;
>> +#ifndef _DJGPP
>> if (_osmode == OS2_MODE)
>> {
>> FSALLOCATE fsa;
>This change looks like a red herring, to me. this is inside an #if
>defined(_EMX) block, already, so DJGPP will never be defined. Or
>rather: if it were, something else, elsewhere in the source, is badly
>mixed up.
This wouldn't have been my choice of how to write the code, but the
unrar source code is set up so that if __DJGPP__ is defined, it defines
_EMX and _DJGPP. Thus you need to exclude any areas that work for DJGPP
but not for EMX. See the unrar file "raros.hpp". To really fix this, you
would probably remove the definition of _EMX for the DJGPP platform,
then look at every instance of #ifdef _EMX and see if it is appropriate
for DJGPP also.
>And while at it: the source sould always test for actual predefined
>platform macros, like __DJGPP__, not self-defined ones like _DJGPP,
>which it is forbidden to define on its own by the C standard.
I agree, but this is throughout the unrar source code. Do a grep on
the files in the distributed source. My patch was just to fix obvious
problems so that it would compile and work. Changing the coding style of
the entire program is something I haven't tried to tackle. The package
is available at: "http://www.rarlab.com/rar/unrarsrc-3.2.2.tar.gz".
Doug
--
Doug Kaufman
Internet: dkaufman AT rahul DOT net
- Raw text -