Mail Archives: djgpp/1997/12/17/20:30:30
Hans Bezemer (hansoft AT geocities DOT com) wrote:
> On 12 Dec 1997 21:38:28 GMT, ulric AT evelin DOT edu DOT stockholm DOT se (Ulric Eriksson)
> wrote:
> >In horror I grepped the .c files to see if this was actually used
> >anywhere. You bet. The first file (4th.c) I looked into contained:
I hate to add to slacking of this guy, because I appreciate the
fact that he is contributing to free software by making his '4th'
package available, but, indeed it's hardly ANSI-C, I looked through
one file and encountered tons of horrible stuff ;
1. A stricmp() function - is in reserved namespace.
2. #include <alloc.h> - doesn't exist in ANSI-C
3. Casting malloc(), calloc(), etc - bad practice.
4. #include <4th.h> - leads to undefined behaviour
And this was just one file, not even mentioning the void main() and
using 'equ' macro's et al (which *can* be used but should be defined by
the appropriate iso header).
Ack, hardly ANSI ...
Cheers, flux.
- Raw text -