Sender:	rich AT phekda DOT freeserve DOT co DOT uk
Message-ID:	<3E2A9590.BDDE0371@phekda.freeserve.co.uk>
Date:	Sun, 19 Jan 2003 12:09:52 +0000
From:	Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer:	Mozilla 4.77 [en] (X11; U; Linux 2.2.23 i586)
X-Accept-Language:	de,fr
MIME-Version:	1.0
To:	djgpp-workers AT delorie DOT com
Subject:	Re: lseek() calling llseek()
References:	<200301181041 DOT h0IAfYc20680 AT brother DOT ludd DOT luth DOT se>
Reply-To:	djgpp-workers AT delorie DOT com

Hello.

Martin Str|mberg wrote:
> You had comments on that lseek() didn't call llseek() (or they both
> calling a common routine). Here's a patch making lseek() call
> llseek().
> 
> Comments are welcome. In particular on my documentation changes and the
> last return statement in lseek() (which could be made safer with some more
> lines of code).

It looks fine to me with your safer return code (from another mail) and some
texinfo fixes.

[snip]
> Index: djgpp/src/libc/fsext/fsext.txh
> ===================================================================
> RCS file: /cvs/djgpp/djgpp/src/libc/fsext/fsext.txh,v
> retrieving revision 1.15
> diff -p -u -r1.15 fsext.txh
> --- djgpp/src/libc/fsext/fsext.txh      8 Jul 2002 12:55:42 -0000       1.15
> +++ djgpp/src/libc/fsext/fsext.txh      18 Jan 2003 09:53:00 -0000
> @@ -98,7 +98,10 @@ A file ioctl handler (@pxref{ioctl (Gene
> 
>  @item __FSEXT_lseek
> 
> -A file lseek handler (@pxref{lseek}).
> +A file lseek handler (@pxref{lseek}).  Here for backwards
> +compatibility.  Use __FSEXT_llseek instead.  If you have a
> +__FSEXT_llseek handler you don't need a __FSEXT_lseek handler as lseek
> +calls llseek internally.
[snip]

You need to use @code{} on __FSEXT_lseek, __FSEXT_llseek, lseek and llseek, I
think.

Thanks, bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]

- Raw text -