Date:	Tue, 28 Aug 2001 09:30:18 +0300 (IDT)
From:	Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender:	eliz AT is
To:	Charles Sandmann <sandmann AT clio DOT rice DOT edu>
cc:	djgpp-workers AT delorie DOT com, wojciech DOT galazka AT polkomtel DOT com DOT pl
Subject:	Re: ODP: Win2K/XP fixes - implementation review
In-Reply-To:	<10108271707.AA15277@clio.rice.edu>
Message-ID:	<Pine.SUN.3.91.1010828092959.1704E-100000@is>
MIME-Version:	1.0
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On Mon, 27 Aug 2001, Charles Sandmann wrote:

> dosexec, crt0, fstat are good for NT 4.0 also, not W2K specific.
> dpmiexcp.c - setting PSP on exit, minor, not file related
> open.c doesn't hurt anything, failure case only.
> _rename.c - additional check for return failure code
> utime.c - better than original code
> _open.c, _creat*.c - more interrupts/file reopens (hurts NT4/LFN)
> 
> The only ones which are W2K specific are the last 3.

I think the set-PSP work-around is also specific to W2K.  It doesn't
hurt, but it slows down by issuing several software interrupts.

> They are only
> on opening files.  If "open" of NUL shows get_dev_info of zero, then
> we should use these patches, else not.  Since we already open nul for
> the FSEXT stuff, we could start assuming no bugs, check for it, if we
> see the bug close nul, turn on the bug-fix-switch continue.

The FSEXT stuff doesn't get called unless the application uses the
extensions.  By default, FSEXT doesn't get linked in.

I agree that it's better to test for the presence of bugs directly,
but this could lead to many tests and many flag variables which tell
what bugs are present.  If we can lump the bugs in a couple of
categories, I think it's okay; otherwise, lets stay with version test.

For now, it sounds like we could get away with only 2 categories:
NT+W2K and W2K-specific (the latter includes XP).  Maybe we should
postpone these decisions a bit more.  I'm not sure we know the whole
extent of the problems right now, although we are close.

- Raw text -