From:	"Tom Demmer" <DEMMER AT brain1 DOT lstm DOT ruhr-uni-bochum DOT de>
Organization:	Lehrstuhl Stroemungsmechanik, RUB
To:	Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>, djgpp-workers AT delorie DOT com
Date:	Wed, 31 Jul 1996 15:28:35 GMT-1
Subject:	Re: The header <sys/ioctl.h>
Reply-to:	Demmer AT LStM DOT Ruhr-Uni-Bochum DOT De
Message-ID:	<40E15845B65@brain1.lstm.ruhr-uni-bochum.de>

[...]
> 
> First impressions:
> 
>     1) The header should be <sys/ioctl.h>, not <ioctl.h>, since that 
> is where it is found on other systems (even in BC++).

Yes, I changed that already.

> 
>     2) I'd recommend to change all "DOS_blabla" constants into 
> "_DOS_blabla" (or even "__DOS"), because these are DJGPP-specific.  If 
> memory serves, names that begin with a `_' are reserved, and this 
> minimizes the possibility of a clash with some application code that uses 
> the same names.

OK, I'll do that.


> 
>     3) The Unix part defines all kind of symbols that aren't supported
> (and probably won't ever be supported) by DJGPP.  Examples are FIONREAD
> and the TIOCxxx macros.  Many programs (e.g. GNU packages) test for these
> symbols and if they are defined, assume support for certain features, even
> if they aren't really connected with these symbols per se.  For instance,
> `cat' from GNU Textutils assumes that values of errno such as `ENOTTY' and
> `EOPNOTSUPP' are defined if FIONREAD is.  This will certainly break DJGPP
> ports of many programs.  I suggest that the Unix part be ifdefed away for
> now, and only those parts are to be activated for which we have full
> support (tested by building the programs which use these symbols). 
>

Hmm. That's why they are inside #if/#endif right now. Maybe that 
should to be changed to #ifdef __IOCTL_SUPPORT_FULL_UNIX_HEADER_
or something like that. The reason why I do not like the idea of 
throwing this completely away is that some file system extension 
might make use of them. OTOH not breaking GNU utils has definitly a 
higher priority. 

Ciao
Tom

  ******************************************************************
  *  Thomas Demmer                     * Phone : +49 234 700 6434  *
  *  Universitaetsstr. 150             * or you try                *
  *  Lehrstuhl fuer Stroemungsmechanik *         +49 234 700 2896  *
  *  D-44780 Bochum                    * and MIGHT get someone who *
  *                                    * knows where I am          *
  *  Demmer AT LStM DOT Ruhr-Uni-Bochum DOT De    * Fax    : +49 234 709-4162 *
  *          http://www.lstm.ruhr-uni-bochum.de/~demmer            *
  ******************************************************************

    UNIX is an operating system, Window$ a shell, and DOS is
    a boot-virus.

- Raw text -