X-Authentication-Warning:	delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient:	djgpp-workers AT delorie DOT com
X-Spam-Checker-Version:	SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status:	No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD
	autolearn=disabled version=3.3.2
Date:	Thu, 01 Feb 2018 18:13:36 +0200
Message-Id:	<83vafgelhr.fsf@gnu.org>
From:	"Eli Zaretskii (eliz AT gnu DOT org) [via djgpp-workers AT delorie DOT com]" <djgpp-workers AT delorie DOT com>
To:	djgpp AT delorie DOT com
CC:	djgpp-workers AT delorie DOT com
In-reply-to:
	<CAA2C=vBTYCSoBbHEVOcUBwAv95+Waq9CMF_TTSvoyJut+zLb_A AT mail DOT gmail DOT com>
	(djgpp AT delorie DOT com)
Subject:	Re: updates to wc206.txi
References:	<CAA2C=vBTYCSoBbHEVOcUBwAv95+Waq9CMF_TTSvoyJut+zLb_A AT mail DOT gmail DOT com>
X-detected-operating-system:	by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From:	2001:4830:134:3::e
Reply-To:	djgpp-workers AT delorie DOT com

> From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]" <djgpp AT delorie DOT com>
> Date: Thu, 1 Feb 2018 10:56:12 +0300
> 
> The following patch updates the 2.06 changelog. Please review.
> If no objections, I'll push it tomorrow.

No objections, just some comments about Texinfo usage:

> +@findex fseeko64 fix

@findex renders everything in typewriter face, as appropriate for
function names.  So if you want to put more than just a function's
name there, you need to switch explicitly to the "normal" Roman
typeface:

  @findex fseeko64 AT r{

Also, just saying "fix" is not informative, please tell more.
Something like

  @findex fseeko64 AT r{, fixed resetting the }_cnt AT r{ field}

> +@findex Compatibility with new gcc versions

This is not about any function, so please use @cindex instead.

> +Compatibility with gcc-6 and newer versions achieved by using proper
> +@code{-fno-builtin-*} compiler flags where needed in library builds.

Options should have the @option markup, not @code.

> +@findex djtar fix

djtar is a program, so please use @pindex instead.

> +Fixed a bug in djtar/unlzh (bug was introduced by djgpp-v2.05.)

"djtar" should be given the @command markup, as it is a program.

Thanks.

- Raw text -