X-Authentication-Warning:	delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient:	djgpp-workers AT delorie DOT com
X-Recipient:	djgpp AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=gmail.com; s=20161025;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc;
	bh=/9fq+HxE/H5TezRzwehsqox4thnpwdPjwVP4XZ2vAgQ=;
	b=iOm69hGKRLUydqJtTzYRLfuzk8AiHQWgzYLhE4lXkvXG2k3dUcOwj0Oup1MPvpQ2k9
	pqByfzmXKbVpWgqKTxngCclEdAn69Pg6zj/OWDGszXuTxIw0rXrmPuEbPH92JXRzXmea
	7KbJ3ZD5sM6sM637FxyAWL6JUxgqPhrl7GhTGvv9iiNrSpdjQF0COP+PsciAdyrkmEp/
	gTRyqlo788SisBetx/6tho1r5yaAXeaiB+vqMt/pFD2DpggUfDK3zWtNfPjI24Imv/Fs
	1HvRnRTKmLINTq0uuJbndonTWzRi/RyKJ3HNKYHb8F5NKltG5z3udQLmMRAhSqPWp3ab
	J8Wg==
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:cc;
	bh=/9fq+HxE/H5TezRzwehsqox4thnpwdPjwVP4XZ2vAgQ=;
	b=LgKfIMJChYpWUha8g0OV2sd+hf116SsUoGZFmSBldLyTCPdirvz2cOCipEgLn98jth
	7dx0e6cVRE9CUMvIKfLaXHlh++p7SD22xmkxryhKOt5kmzq80+D/MEtxSojbCy9XwMU2
	38iQCWEx1hfj1/mLch0UbhxnXHhxEz9ht3l4TaCt7jdTAHlItDthDleXUQUDAhzPV/fM
	BHyiNF8BqxnK8bJS1KZ2vBOapigjR6vy5GEerOQemElo2GfgG/c1Web8E12Lut5yzBLc
	0vCTQSwlcXe9qxhZ0lrcel8WMB4TjnR2Qo2JzclbWeMA8wUF3oL6SZVRdn7p3f/jApFQ
	XIiw==
X-Gm-Message-State:	AIkVDXKr8rF4H5k6VoGh8sMkgO67sVshGs6lNmgYiFFSVXu97kWb6rsV9rclKjY75HS2lfK/PRQutjDdD3Fs4g==
X-Received:	by 10.107.146.2 with SMTP id u2mr21833211iod.217.1484395864200;
	Sat, 14 Jan 2017 04:11:04 -0800 (PST)
MIME-Version:	1.0
In-Reply-To:	<83d1fpc24q.fsf@gnu.org>
References:	<CAA2C=vAxwXB1-nsiDMmKQLt7rmkFHonK-8Cxqx4M_2uKN7ZzPA AT mail DOT gmail DOT com>
	<83h951c41o DOT fsf AT gnu DOT org> <CAA2C=vAQsONZ-bG1dnoso3RWno6bDWGeDhnMJk33RypA5JjG=A AT mail DOT gmail DOT com>
	<83d1fpc24q DOT fsf AT gnu DOT org>
From:	"Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp-workers AT delorie DOT com]" <djgpp-workers AT delorie DOT com>
Date:	Sat, 14 Jan 2017 15:11:03 +0300
Message-ID:	<CAA2C=vA8sYus1m75UbeBvgJw_QQ-rs=RDc3hmpfSV_+1kYd3ug@mail.gmail.com>
Subject:	Re: memory.h
To:	djgpp-workers AT delorie DOT com
Cc:	djgpp AT delorie DOT com
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On 1/14/17, Eli Zaretskii (eliz AT gnu DOT org) [via
djgpp-workers AT delorie DOT com] <djgpp-workers AT delorie DOT com> wrote:
>> From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]"
>> <djgpp AT delorie DOT com>
>> Date: Sat, 14 Jan 2017 14:16:05 +0300
>> Cc: djgpp-workers AT delorie DOT com
>>
>> IMO, there is no excuse in including stdlib.h instead of string.h from
>> memory.h.  Possibly it was a typo?
>
> Doesn't look like a typo to me: in DJGPP v1, memory.h included
> djgppstd.h, which was a hodge-podge of functions, including many in
> stdlib.h.
>
> What problems does including stdlib.h cause?

Problems are not from including stdlib.h but from not including string.h
E.g. cpu.c from flac library includes memory.h possibly to get the proto
for memset(). Their decision might be debatable, but that's what they do
and it works everywhere except for djgpp, for which I suggested a patch
http://lists.xiph.org/pipermail/flac-dev/2017-January/006109.html

>  Would it be okay to
> simply add string.h, without removing stdlib.h?  That way, we don't
> create possible backward incompatibilities that could break existing
> programs.
>

That's good with me. Should I push it to cvs?

- Raw text -