X-Authentication-Warning:	delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient:	djgpp-workers AT delorie DOT com
Subject:	Fwd: A few DJGPP libc.a bugs
References:	<56F8295E DOT 2090401 AT posteo DOT de>
To:	djgpp-workers AT delorie DOT com
From:	"Andris Pavenis (andris DOT pavenis AT iki DOT fi) [via djgpp-workers AT delorie DOT com]" <djgpp-workers AT delorie DOT com>
X-Forwarded-Message-Id:	<56F8295E DOT 2090401 AT posteo DOT de>
Message-ID:	<571E403D.8080709@iki.fi>
Date:	Mon, 25 Apr 2016 19:05:17 +0300
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.7.1
MIME-Version:	1.0
In-Reply-To:	<56F8295E.2090401@posteo.de>
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Sent to me privately. I suggested author to send it to list. I have not seen however any activity 
since that.
So I'm forwarding message to list.

I'm also committing the proposed patch for ttyscrn.c.

Andris

-------- Forwarded Message --------
Subject: 	A few DJGPP libc.a bugs
Date: 	Sun, 27 Mar 2016 20:41:34 +0200
From: 	felix <felix DOT von DOT s AT posteo DOT de>
To: 	andris DOT pavenis AT iki DOT fi



Hello,

I'd like to report two bugs in DJGPP 2.05 libc.a. While I have found a
bug tracker of sorts at <http://www.delorie.com/djgpp/bugs/>, it looks
quite untended, to say the least. On the other hand, I found your
address with the recent DJGPP release announcements, so I figure if I
send this here someone might read it.

One of them is a simple typo.

--- src/libc/posix/termios/ttyscrn.c
+++ src/libc/posix/termios/ttyscrn.c
@@ -464,7 +464,7 @@
      __dpmi_int(0x10, &r);
      if (++(*col) > __tty_screen.max_col)
      {
-      col = 0;
+      *col = 0;
        ++row;
      }
      __tty_screen.set_cursor(*col, *row);

The other one is more complicated. The fseeko64() function, unlike plain
fseek(), doesn't take care of the FILE* buffer, which may cause later
reads to return invalid data. I found this one after cross-compiling gdb
for DOS on my own.

May I suggest putting djcrx and djlsr on savannah.nongnu.org or
wherever?And maybe changing VCSes on the way...

--f

- Raw text -