X-Authentication-Warning:	delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient:	djgpp-workers AT delorie DOT com
Message-ID:	<52945E44.70901@iki.fi>
Date:	Tue, 26 Nov 2013 10:39:32 +0200
From:	Andris Pavenis <andris DOT pavenis AT iki DOT fi>
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version:	1.0
To:	djgpp-workers AT delorie DOT com
Subject:	Re: Wrong order of memalign arguments
References:	<5293DBB3 DOT 6020501 AT gmx DOT de>
In-Reply-To:	<5293DBB3.6020501@gmx.de>
Reply-To:	djgpp-workers AT delorie DOT com

On 11/26/2013 01:22 AM, Juan Manuel Guerrero wrote:
> As Rugxulo pointed out a couple of days before there is a very serious bug in
> memalign.  It concerns the reversed order of memalign arguments. From the very
> first check in of this file, the function arguments were swapped. I am not
> familiar enough with unix and bsd history, so I do not know if the reversed
> argument order was ever the right order.  According to my linux man page this
> is not the case.

Succeeded to dig out the first Linux distribution which I have tried 18 years
ago (Slackware 3.0, released in 1995). It has arguments in the same order as now
in Linux. I do not know about more ancient times though

Perhaps nobody noticed that arguments are in wrong order in 2001

Also saw that nmalloc has the same wrong argument order. I'm using
nmalloc for DJGPP port of GCC (DJGPP v2.04 own malloc or more exactly
free() is too slow). Fortunately memalign is not used in GCC parts
supported for DJGPP native build, so nothing gets broken.

Andris

- Raw text -