X-Authentication-Warning:	delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient:	djgpp-workers AT delorie DOT com
Date:	Wed, 17 Jul 2013 18:24:10 +0300
From:	Eli Zaretskii <eliz AT gnu DOT org>
Subject:	Re: Set _IOERR if the file stream has been opened in wrong mode.
In-reply-to:	<51E5D0C6.1060404@gmx.de>
X-012-Sender:	halo1 AT inter DOT net DOT il
To:	djgpp-workers AT delorie DOT com
Message-id:	<83y5951a79.fsf@gnu.org>
References:	<51E5D0C6 DOT 1060404 AT gmx DOT de>
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> Date: Wed, 17 Jul 2013 01:01:26 +0200
> From: Juan Manuel Guerrero <juan DOT guerrero AT gmx DOT de>
> 
> Please inspect the code snippet below:
> 
> #include <stdio.h>
> 
> int main(void)
> {
>    char buffer[1024];
>    FILE *f = fopen("foobar.txt", "w");
> 
>    clearerr(f);
> 
>    if (fgets(buffer, sizeof(buffer), f) == NULL)
>      printf("EOF encountered before data\n");
> 
>    printf("ferror = %s\n", ferror(f) ? "TRUE" : "FALSE");
>    printf("feof = %s\n", feof(f) ? "TRUE" : "FALSE");
> 
>    return 0;
> }
> 
> 
> The code snippet is not arbitrary (especially the "w" mode instead of the "w+"
> mode in the fopen function) but represents a compilable and working version of
> the code produced by the lua interpreter for the first two lines of the
> following lua code snippet:
> 
>    local f = io.open("foobar.txt", "w")
>    local r, m, c = f:read()
>    assert(r == nil and ismsg(m) and type(c) == "number")
> 
> 
> The above code is part of a test suite and it shall fail because it tries to
> read from a file opened to be written.  The second line fails and initializes
> the variables in such a way that the assert is not triggert (the data is a
> error message and the file descriptor, but that is of no importance here).
> This is the way the test shall work and this is the way the code works if lua
> has been compiled on linux.  If lua is compiled using any version of djgpp,
> the second line:
>    local r, m, c = f:read()
> behaves in a different way (it does not fail, among other things) and the
> variables are initialized with nonsense data making the following assertion
> to be triggert and thus aborting the complete test suite.
> 
> The reason for the different behavior of lua's :read() function is the
> different way the ferror function has been implemented on linux and djgpp.
> 
> The issue concerns the fread, fwrite, __putc and __getc functions only.
> These functions manipulate the file stream FILE *.  Functions like read,
> _read and dos_read are not involved because they work with the file descriptor.
> If these functions fail due to accessing the file with wrong file mode,
> they set the appropriate dos error number.
> Of course, ferror can only fail for those functions that use the file stream.
> 
> The patch below will fix the issue for read and write functions.
> As usual, suggestions, objections, comments are welcome.

What standard mandates that reading from a file stream open in "w"
mode shall set the error flag for the stream?

DJGPP currently sets the EOF flag, not the error flag.  Why is that
wrong?

- Raw text -