X-Authentication-Warning:	delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient:	djgpp-workers AT delorie DOT com
X-Authenticated:	#27081556
X-Provags-ID:	V01U2FsdGVkX195QFBGJBB5zF47u0qzqvxUosJkUbPtoznuJNQACo
	oCvtCI258HhKja
Message-ID:	<50BE474B.9000204@gmx.de>
Date:	Tue, 04 Dec 2012 19:56:11 +0100
From:	Juan Manuel Guerrero <juan DOT guerrero AT gmx DOT de>
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2
MIME-Version:	1.0
To:	djgpp-workers AT delorie DOT com
CC:	Ozkan Sezer <sezeroz AT gmail DOT com>
Subject:	Re: src/debug/fsdb/fullscr.c r1.12
References:	<CAA2C=vA8kNDh=c5jXJ1r0TxVPuvKz-QViG222j=oDghS-UxeLA AT mail DOT gmail DOT com> <CAA2C=vD+ykMBRW2wBsSbgD83VjjediRt=eCZbMy4aQXS1fkG2g AT mail DOT gmail DOT com>
In-Reply-To:	<CAA2C=vD+ykMBRW2wBsSbgD83VjjediRt=eCZbMy4aQXS1fkG2g@mail.gmail.com>
X-Y-GMX-Trusted:	0
Reply-To:	djgpp-workers AT delorie DOT com

Am 04.12.2012 18:45, schrieb Ozkan Sezer:
> On 12/4/12, Ozkan Sezer <sezeroz AT gmail DOT com> wrote:
>> Hi:
>>
>> As far as I can see unassemble_proper() sets its len param, however
>> src/debug/fsdb/fullscr.c r1.12 comments out the call to avoid set-but-
>> unused warnings but 'len' is used two lines below.  So, unless I am
>> missing something, the following is needed.
>>
> Slightly updated patch below.  (BTW, the whole thing can actually use
> some constification: things like char* str="string"; are everywhere..)
>
>
You are right.  I missed something when I tried to fix set-but-unused
warnings.  Your patch is OK.
If you provide a patch with constantifications of strings I will commit
it.  At a first glance I found only one but I may have missed more.

Regards,
Juan M. Guerrero

- Raw text -