X-Authentication-Warning:	delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient:	djgpp-workers AT delorie DOT com
Date:	Fri, 30 Sep 2011 12:35:13 +0300
From:	Eli Zaretskii <eliz AT gnu DOT org>
Subject:	Re: [Patch] Issues concerning the INT 21 Windows95 - LONG FILENAME FUNCTIONS (0x71XX) implementation.
In-reply-to:	<201109282235.01944.juan.guerrero@gmx.de>
X-012-Sender:	halo1 AT inter DOT net DOT il
To:	djgpp-workers AT delorie DOT com
Message-id:	<8362kae5ke.fsf@gnu.org>
References:	<201109282235 DOT 01944 DOT juan DOT guerrero AT gmx DOT de>
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> From: Juan Manuel Guerrero <juan DOT guerrero AT gmx DOT de>
> Date: Wed, 28 Sep 2011 22:35:01 +0200
> 
> This is the last version of the patch to presented by me to fix the pending
> issues concerning the use of 0x7XX functions from the LFN API of windows.

Thanks.  A couple of minor nits:

> +@findex _use_lfn AT r{, LFN support on plain DOS with DOSLFN and other LFN drivers}
> +@findex _rename AT r{, LFN support on plain DOS with DOSLFN and other LFN drivers}
> +All these functions now check that the used LFN driver supplies the required

"All these functions" will look mysterious in the manual, because all
the preceding @findex entries disappear without a trace from the
manual text.  Suggest to say something like "Many low-level library
functions..." instead.

> -    int idx = sizeof(try_char)-1;
> +    int idx = sizeof(try_char) - 1;

This kind of whitespace changes really doesn't belong with this patch.

> -  for (i=0; i<2; i++)
> +  for (i = 0; i < 2; i++)
>    {
> -    if(use_lfn)
> +    if (use_lfn)

Likewise (here and elsewhere).

Thanks again for working on this.

- Raw text -