X-Authentication-Warning:	delorie.com: mail set sender to djgpp-workers-bounces using -f
Date:	Thu, 30 Dec 2004 02:02:31 -0700
From:	Brian Inglis <Brian DOT Inglis AT SystematicSw DOT ab DOT ca>
Subject:	Re: setlocale patch
In-reply-to:	<41D39F08.000032.31528@pantene.yandex.ru>
To:	djgpp-workers AT delorie DOT com
Message-id:	<d1g7t0tv98r0navdqcv9ncdambsp1ucg87@4ax.com>
Organization:	Systematic Software
MIME-version:	1.0
X-Mailer:	Forte Agent 1.93/32.576 English (American)
References:	<200412291442 DOT iBTEgSJO014313 AT speedy DOT ludd DOT ltu DOT se>
	<41D39F08 DOT 000032 DOT 31528 AT pantene DOT yandex DOT ru>
X-MIME-Autoconverted:	from quoted-printable to 8bit by delorie.com id iBU93UfX007829
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On Thu, 30 Dec 2004 09:24:08 +0300 (MSK), Alexander Aganichev
<aaganichev AT yandex DOT ru> wrote:

>That's bad, collate table should not be all zeroes. Which OS you running on?
>I will try to review Brian's changes and provide updated liblocal.

Please also look at recent posts on thread "C99 strftime and Related
Changes".

>>Is there a more complete test program for tests/...?
>
>It's hard to provide that code since it should be different for the
>different locales. The one idea is to generate all possible locales
>and verify only "C", "POSIX", default (by returning name and compare
>to file) and something odd.

I added something along those lines to the strftime() tests in
xstrftm.c: locales NULL, "", custom, "C"; which is how I found a reset
locale bug, ended up making those changes to setlocale(), and resulted
in adding other locale and timezone tests to the strftime() tests. 

IIRC C and POSIX are synonyms for reset, so did not add the POSIX case
to xstrftm.c, but perhaps we should add that as a regression case to
the locale related tests to check the status quo. 

- Raw text -