Mail Archives: djgpp-workers/2004/01/13/17:03:47
Hello.
Esa A E Peuha wrote:
> On Mon, 12 Jan 2004, Richard Dawe wrote:
>
>
>>The code you committed for this was not the same as the code you posted.
>>If you're going to commit different code, please say why in a message to
>>djgpp-workers.
>
>
> I did post the code I committed (see djgpp-workers/2004/01/08/04:56:08,
> M-ID <Pine DOT OSF DOT 4 DOT 58 DOT 0401081152420 DOT 23737 AT sirppi DOT helsinki DOT fi>), or at
> least that was what I intended. Did I somehow manage to mess it up?
No, it's me. I missed that message, when I was going through my mail box
last night. Sorry.
>>Incidentally, I don't understand why it was commmitted to CVS, when Eli
>>was not happy with it.
>
>
> Eli was concerned about possible problems with debugging. I asked what
> problems have been caused by having the current getc/putc code (also
> used in fgetc/fputc, fgets/fputs and getchar/putchar) as inline
> functions in a header. Since Eli didn't answer that question, I assumed
> (perhaps mistakenly) that he didn't object to committing. I am sorry if
> I was wrong.
If you're not sure, it's best to ask.
I think we agreed on the list sometime ago to wait a week before
comitting things, so people have a chance to reply to mail. Waiting
until after a weekend is a good idea. That's so that people can review
patches at the weekend, when they may have more time.
Bye, Rich =]
PS: Sorry again about missing your second patch!
--
Richard Dawe [ http://homepages.nildram.co.uk/~phekda/richdawe/ ]
"You can't evaluate a man by logic alone."
-- McCoy, "I, Mudd", Star Trek
- Raw text -