From:	<ams AT ludd DOT luth DOT se>
Message-Id:	<200302081446.h18EkiQ24457@speedy.ludd.luth.se>
Subject:	Re: Take on __solve_symlinks()
In-Reply-To:	<3E450859.9090508@mif.vu.lt> "from Laurynas Biveinis at Feb 8, 2003
	02:38:33 pm"
To:	djgpp-workers AT delorie DOT com
Date:	Sat, 8 Feb 2003 15:46:44 +0100 (CET)
X-Mailer:	ELM [version 2.4ME+ PL78 (25)]
MIME-Version:	1.0
X-MailScanner:	Found to be clean
X-MailScanner-Information:	Please contact the ISP for more information
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

According to Laurynas Biveinis:
> Maybe it's W98 vs W2K thing? Could somebody else with W98/W2K test
> tests/libc/compat/unistd/xsymlink.c to see if it fails? In any case, I'm

1. This patch is nice:
diff -p -u -r1.5 xsymlink.c
--- djgpp/tests/libc/compat/unistd/xsymlink.c   23 Dec 2002 11:46:10 -0000      1.5
+++ djgpp/tests/libc/compat/unistd/xsymlink.c   8 Feb 2003 14:38:07 -0000
@@ -93,7 +93,7 @@ int main(void)
        !__file_exists("dir1/test5") || !__file_exists("dir1/test6") ||
        !__file_exists("dir1/test7") || access("dir1/dir2", D_OK))
    {
-       fprintf(stderr, "Required data files not found");
+       fprintf(stderr, "Required data files not found\n");
        exit(1);
    }
    puts("Running __solve_symlinks() and readlink() testsuite:");

2. You need to checkin djgpp/tests/libc/compat/unistd/dir1/dir2.

3. It fails here:
Running __solve_symlinks() and readlink() testsuite:
Tests that check __solve_symlinks() works:
Test 1 passed
Test 2 passed
Test 3 passed
Test 4 passed
Test 5 passed
Test 6 passed
Test 7 passed
Test 8 passed
Test 9 passed
Test 10 passed
Test 11 passed
Test 12 passed
Test 13 passed
Tests that check __solve_symlinks() based on current directory:
Test 1: Solving e:/djgpp/tests/libc/compat/unistd/../../../../../djgpp/tests/libc/compat/unistd/test1
Test 1 passed
Test 2: Solving e:../../../../../djgpp/tests/libc/compat/unistd/test1
Test 2 passed
Test 3: Solving e:../../../../../../djgpp/tests/libc/compat/unistd/test1
Test 3 failed - __solve_symlinks returns wrong resolved path
Returned path: e:/djgpp/tests/libc/compat/unistd/test1
Expected path: e:/djgpp/tests/libc/compat/unistd/file1
Tests that check __solve_symlinks() failure cases:
Test 1 passed
Test 2 passed
FAIL

I'm using WINDOZE 98, bash and CVS of today (030208).


Right,

						MartinS

- Raw text -