Mail Archives: djgpp-workers/2002/12/01/14:53:38
Hello.
Charles Sandmann wrote:
>
> > > strtold is now a standard function. Below is a patch with instructions.
> > > Basically the patch adds a stub strtold, which calls _strtold.
>
> > If strtold is a standard function, stubbing it seems wrong. I know
> > it's consistent with our rules, it's just feels weird.
>
> We could rename the function and stub _strtold. I don't care either way.
I think we should make strtold call _strtold. Reasoning: Consider _strtold
calling strtold. You can compile code for the C89 standard using the -std=c89
option of gcc. If _strtold calls strtold, we pollute the C89 namespace with a
C99 function, when someone uses _strtold. With strtold calling _strtold, this
does not happen.
> > > Step 1: Rename src/libc/ansi/stdlib/strtold.c to _strtold.c.
> >
> > Do we really need to rename files just because of an underscore? We
> > don't do that for other stubbed functions.
>
> I agree - I don't think renaming the file is necessary
OK.
Bye, Rich =]
--
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]
- Raw text -