delorie.com/archives/browse.cgi | search |
From: | sandmann AT clio DOT rice DOT edu (Charles Sandmann) |
Message-Id: | <10211281801.AA13105@clio.rice.edu> |
Subject: | Re: _Exit function [PATCH] |
To: | djgpp-workers AT delorie DOT com |
Date: | Thu, 28 Nov 2002 12:01:28 -0600 (CST) |
In-Reply-To: | <E18HMv0-0000iC-00@phekda.freeserve.co.uk> from "Richard Dawe" at Nov 28, 2002 11:37:13 AM |
X-Mailer: | ELM [version 2.5 PL2] |
Mime-Version: | 1.0 |
Reply-To: | djgpp-workers AT delorie DOT com |
Errors-To: | nobody AT delorie DOT com |
X-Mailing-List: | djgpp-workers AT delorie DOT com |
X-Unsubscribes-To: | listserv AT delorie DOT com |
Looks good to me. Only one comment (library space and efficiency): include/libc/stubs.h is used to create "aliases" similar to this that we use for namespace fixes. Should we also use this to create simple jump stubs like this one? added to include/libc/stubs.h: #define _Exit _exit It would be a new use (abuse?) of libc/stubs.h It does make finding the "source" harder, but it makes smaller libraries and executables, and we don't need a source module for "_Exit" - it's automatically written. And no need to modify a makefile either. > OK to commit? Fine with me, I just thought I would bring the above issue up (it's not the first time, and probably not the last ...
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |