X-Authentication-Warning:	delorie.com: mailnull set sender to djgpp-workers-bounces using -f
Date:	Sat, 13 Apr 2002 12:13:28 +0300
From:	"Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender:	halo1 AT zahav DOT net DOT il
To:	Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
Message-Id:	<5832-Sat13Apr2002121327+0300-eliz@is.elta.co.il>
X-Mailer:	emacs 21.2.50 (via feedmail 8 I) and Blat ver 1.8.9
CC:	djgpp-workers AT delorie DOT com
In-reply-to:	<3CB7E2B4.9A956584@phekda.freeserve.co.uk> (message from Richard
	Dawe on Sat, 13 Apr 2002 08:48:04 +0100)
Subject:	Re: Patch: fchown()
References:	<Pine DOT SUN DOT 3 DOT 91 DOT 1000119115250 DOT 9609S-100000 AT is> <3885B091 DOT 2A75187C AT softhome DOT net> <3CAD96E3 DOT 586DBA4A AT phekda DOT freeserve DOT co DOT uk> <9003-Fri05Apr2002184824+0300-eliz AT is DOT elta DOT co DOT il> <3CB7E2B4 DOT 9A956584 AT phekda DOT freeserve DOT co DOT uk>
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> Date: Sat, 13 Apr 2002 08:48:04 +0100
> From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
> 
> I've just committed the patch, with some changes:

Thanks.

I have some minor comments.

  - fchown.txh needs at least to say what this function does in
    general.  Otherwise, people who want to implement the
    functionality via FSEXT will not know what code to write.

  - since fchown is a trivial implementation, we should add it to the
    menu in libc.tex.

  - fsext.txh says the fchown handler is called ``when file
    attributes are changed for an open file.''  I think you should
    replace ``attributes'' with ``ownership.''

  - wc204.txi talks about fchmod instead of fchown.

Thanks again for working on this (and to Laurinas for coding it in
the first place).

- Raw text -