X-Authentication-Warning:	delorie.com: mailnull set sender to djgpp-workers-bounces using -f
Date:	Tue, 25 Dec 2001 13:41:48 +0200 (IST)
From:	Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender:	eliz AT is
To:	Charles Sandmann <sandmann AT clio DOT rice DOT edu>
cc:	djgpp-workers AT delorie DOT com
Subject:	Re: v2.03 refresh issue - passing 3K argument list [was Re: A new bug?]
In-Reply-To:	<10112241537.AA19140@clio.rice.edu>
Message-ID:	<Pine.SUN.3.91.1011225133854.5289D@is>
MIME-Version:	1.0
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On Mon, 24 Dec 2001, Charles Sandmann wrote:

> > I wonder if this has something to do with the glob buffer overrun that was 
> > fixed some time ago. The glob routines use a buffer that is 2000 bytes long.
> 
> This change is NOT in the refresh - it looks very much like it should be.
> I will try rebuilding a bash 2.04 with this module and see if the problem
> goes away.  The sizing and usage convinces me this is the fix...
> 
> What is the risk of adding this to the refresh vs. leaving the bug in?

The risk of adding it is IMHO negligible, since the change simply tests a 
pointer against a fixed value and bails out if the test fails.

The risk of leaving the bug in is that people will not be able to build 
Bash without either resorting to local hacks, or using the CVS library.  

So my advice would be to add it.

- Raw text -