X-Authentication-Warning:	delorie.com: mailnull set sender to djgpp-workers-bounces using -f
Date:	Sat, 01 Dec 2001 20:10:35 +0200
From:	"Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender:	halo1 AT zahav DOT net DOT il
To:	Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
Message-Id:	<6551-Sat01Dec2001201035+0200-eliz@is.elta.co.il>
X-Mailer:	emacs 21.1.50 (via feedmail 8 I) and Blat ver 1.8.9
CC:	djgpp-workers AT delorie DOT com
In-reply-to:	<3C0914A1.662F7F8F@phekda.freeserve.co.uk> (message from Richard
	Dawe on Sat, 01 Dec 2001 17:34:25 +0000)
Subject:	Re: st_blksize patch, revision 4
References:	<3C08FA41 DOT B9181F10 AT phekda DOT freeserve DOT co DOT uk> <2945-Sat01Dec2001183513+0200-eliz AT is DOT elta DOT co DOT il> <3C0914A1 DOT 662F7F8F AT phekda DOT freeserve DOT co DOT uk>
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> Date: Sat, 01 Dec 2001 17:34:25 +0000
> From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
> 
> The 'if (true)' part is conditional on __get_fd_name() returning non-zero,
> so filename will never be NULL. Maybe I should explicitly check that it's
> non-NULL, rather than assuming NULL == 0:

No, there's no need.  It's my fault that I didn't see that `if'.

> I've just noticed _STAT_* are defined in fstat.c & lstat.c too, so I'll
> remove those.

Yes, please.

> There are some combinations of stat flags, e.g.
> _STAT_EXECBIT, that are used in *stat.c. Shall I move these to sys/stat.h
> and document in __djstat_flags texinfo docs?

I don't think it's necessary: no other code uses that, IIRC.

- Raw text -