From:	pavenis AT lanet DOT lv
To:	"Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>, djgpp-workers AT delorie DOT com,
	acottrel AT ihug DOT com DOT au, djgpp-workers AT delorie DOT com
Date:	Tue, 14 Aug 2001 11:22:21 +0300
MIME-Version:	1.0
Subject:	Re: Windows 2000 patch for utime.c
Message-ID:	<3B7909ED.32020.19CCE6@localhost>
In-reply-to:	<4634-Tue14Aug2001101525+0300-eliz@is.elta.co.il>
References:	<10108140514 DOT AA13389 AT clio DOT rice DOT edu> (sandmann AT clio DOT rice DOT edu)
X-mailer:	Pegasus Mail for Win32 (v3.12c)
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On 14 Aug 2001, at 10:15, Eli Zaretskii wrote:

> > From: sandmann AT clio DOT rice DOT edu (Charles Sandmann)
> > Date: Tue, 14 Aug 2001 00:14:40 -0500 (CDT)
> > 
> > > +   if (_osmajor == 5 &&
> > > +       (_USE_LFN)    &&
> > > +       (_get_dos_version(1) == 0x532)) /* LFN and NT (or 2000 or XP) */
> > > +   {
> > 
> > I suggest we create a new global: extern short _os_true_version
> > so we can change this to:
> > 
> >       if (_USE_LFN && _os_true_version == 0x532)
> 
> I think we should consider this later, when we have a better notion of
> how many places need this.  Note that the conditions are carefully
> arranged to call _get_dos_version as the last resort, so the only
> systems which are punished are DOS 5 machines with NTLFN installed,
> and W2K itself.

If we would have such variable it could be initialized only once at 
startup. Yesterday I run into trouble when tried to call 
_get_dos_version() in bad place inside dosexec.c. Checking a 
global variable where needed would be more safe. So I suggest to 
introduce this variable now.

Andris

- Raw text -