From:	"Tim Van Holder" <tim DOT van DOT holder AT pandora DOT be>
To:	<djgpp-workers AT delorie DOT com>
Subject:	Re: Compiler options for djdev build
Date:	Sun, 10 Jun 2001 10:42:20 +0200
Message-ID:	<CAEGKOHJKAAFPKOCLHDIGEAKCEAA.tim.van.holder@pandora.be>
MIME-Version:	1.0
X-Priority:	3 (Normal)
X-MSMail-Priority:	Normal
X-Mailer:	Microsoft Outlook IMO, Build 9.0.2416 (9.0.2910.0)
In-reply-to:	<1190-Sat09Jun2001231319+0300-eliz@is.elta.co.il>
Importance:	Normal
X-MimeOLE:	Produced By Microsoft MimeOLE V5.50.4133.2400
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> > What I'm saying is todigit() is declared before its use. todigit()
> > expects a char as its argument (in the original code). Ok?
> > 
> > Why is gcc complaining? 
> > 
> > Because we used the flag -Wconversion. 
> 
> GCC is complaining because we asked it to with -Wconversion.  I think
> -Wconversion is useful because it flags code that could break if small
> changes are introduced into the code.

From what has been said, it would only break if chars, shorts or floats
were passed to a function without a prototype.  But using a function
without a prototype is also flagged as a warning, isn't it?  So this
shouldnt be a problem - we're warned if there's no prototype, and if
there is one, the compiler knows how to handle the arguments.

IMHO, the annoyance of getting this kind of warning far outweighs the
usefulness of getting 'x = -1' (where x is unsigned) flagged (the only
other effect of -Wconversion).

- Raw text -