Date:	Fri, 02 Mar 2001 12:29:52 +0200
From:	"Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender:	halo1 AT zahav DOT net DOT il
To:	Hans-Bernhard Broeker <broeker AT physik DOT rwth-aachen DOT de>
Message-Id:	<2950-Fri02Mar2001122951+0200-eliz@is.elta.co.il>
X-Mailer:	Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.6
CC:	djgpp-workers AT delorie DOT com
In-reply-to:	<Pine.LNX.4.10.10103020948560.9692-100000@acp3bf> (message from
	Hans-Bernhard Broeker on Fri, 2 Mar 2001 10:44:43 +0100 (MET))
Subject:	Re: strtol fix correct?
References:	<Pine DOT LNX DOT 4 DOT 10 DOT 10103020948560 DOT 9692-100000 AT acp3bf>
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> Date: Fri, 2 Mar 2001 10:44:43 +0100 (MET)
> From: Hans-Bernhard Broeker <broeker AT physik DOT rwth-aachen DOT de>
> > 
> > I patched a copy of DJGPP CVS and ran the tests. The summary info is:
> > 
> >     Tested 63223 functions, 410 errors detected
> 
> That's what I see, too. I did zip up the CVS version and take it home,
> yesterday evening. I first ran the unmodified libc, which showed 410
> errors, saved away the 'results' file'

There is already a canonical results file in the djtst distribution,
which should be the base for comparison, as the readme there explains.

> The result differs from all the 'standard' versions that
> come with the CVS sources, but that's caused by compiler version
> differences, I assume.

I don't see what does the compiler version have to do with the
results: they depend on the library sources, not on the compiler
version.  If the machine code generated from the library sources
depends on the compiler version in a way that affects the results, we
are in deep trouble, IMHO.

Could you please post the diffs against the file `stadard.results'
from djtst203.zip?

> So here's the patch. I changed the whole strto*l family as described
> yesterday. While being at it, I also made a somewhat related change to
> strtod.c: it used explicit comparisons to ' ' and '\t' to check for
> whitespace, instead of isspace().

I assume that you ran the test suite after all these changes, right?

Thanks for the patches, assuming that the diffs against the standard
testsuite results are insignificant, or don't pertain to these
functions, I will apply them.

- Raw text -