From:	Bruno Haible <haible AT ilog DOT fr>
MIME-Version:	1.0
Message-ID:	<15002.27643.448799.416439@honolulu.ilog.fr>
Date:	Mon, 26 Feb 2001 15:45:15 +0100 (CET)
To:	Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
Cc:	ST001906 AT HRZ1 DOT HRZ DOT TU-Darmstadt DOT De, djgpp-workers AT delorie DOT com
Subject:	Re: DJGPP specific patch for libiconv-1.5.1
In-Reply-To:	<8011-Fri23Feb2001101102+0200-eliz@is.elta.co.il>
References:	<2BDF13E1437 AT HRZ1 DOT hrz DOT tu-darmstadt DOT de>
	<8011-Fri23Feb2001101102+0200-eliz AT is DOT elta DOT co DOT il>
X-Mailer:	VM 6.72 under 21.1 (patch 8) "Bryce Canyon" XEmacs Lucid
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Eli Zaretskii writes:

> >           (usage) [O_BINARY]: Print --binary option.
> 
> I probably missed this when I read your previous set of patches.
> 
> Why is the --binary option needed?  Why cannot the files be always
> read and written in binary mode?

1) Because iconv deals with text. Text files are opened with "r", not
"rb".

2) Because when reading from stdin or writing to stdout, special work
is needed to get that file into binary mode. It should not be the
default.

Bruno

- Raw text -